[release-16.0] Remove recent golangci-lint version bump #12909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
requested review from
deepthi,
mattlord and
rohit-nayak-ps
as code owners
harshit-gangal
approved these changes
Apr 17, 2023
deepthi
approved these changes
Apr 17, 2023
timvaillancourt
pushed a commit
to slackhq/vitess
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
4 tasks
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
Mar 15, 2024
* go1.20.14 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * more go-version: updates Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make proto w/go1.20 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix the golangci-lint config (vitessio#11812) There's a bunch of deprecated linters that don't work anymore, so let's remove them: ``` WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. ``` Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * update golangci-lint to 1.50.1 (vitessio#11873) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add timeout to golangci-lint and bump its version (vitessio#12852) (vitessio#12853) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Upgrade `release-16.0` to `go1.20.1` (vitessio#12398) * Upgrade release-16.0 to go1.19.6 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * upgrade to 1.20.1 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * bump the golangci-lint version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply linter suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply linter suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix TestTLSClientVerifyIdentity Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Switch to using new Go 1.19 CRL parser (vitessio#12315) `x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList` instead which is new in Go 1.19. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Skip TestFuzz for now Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove recent golangci-lint version bump (vitessio#12909) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix conflict resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make ensure_bootstrap_version Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * hardcode previous release Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add comment for hardcoded previous release Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts the golangci-lint version upgrade that was done in #12854