-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the 200
indentation limit in the SQL parser
#13158
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a passing test that has an indentation of over 200 just to make sure it works and we don't end up breaking it in the future.
There is one already in |
I was unable to backport this Pull Request to the following branches: |
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui Could you point me to it? All I see is a test that was failing on |
Description
This PR removes the indentation limit of
200
which was introduced 8 years ago in #845. The original reason for this limit was to prevent stack overflow, however, there is little chance to reach stack overflow. There are already a lot of possibilities to OOM the VTGate by sending weird queries.cc @arthurschreiber @GuptaManan100
Related Issue(s)
Fixes: #13159
Checklist
Deployment Notes