Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-16.0]: Fix upgrade-downgrade test setup and fix the init_db.sql #13525

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Jul 18, 2023

Description

This PR fixes the ugprade-downgrade test setup which was installing the incorrect versions of binaries. After fixing this change, the test fails which prompted the change in init_db.sql file.
In release-17.0 the super read only work was done and it was turned on. In order to preserve downgrade path we need to fix init_db.sql bundled in release-16.0 to turn off super_read_only when it is executed.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 18, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 18, 2023
@github-actions github-actions bot added this to the v16.0.3 milestone Jul 18, 2023
@GuptaManan100 GuptaManan100 added Type: Testing Component: Backup and Restore Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jul 18, 2023
@GuptaManan100 GuptaManan100 marked this pull request as ready for review July 18, 2023 09:53
@GuptaManan100 GuptaManan100 changed the title Fix upgrade-downgrade test setup and fix the init_db.sql [release-16.0]: Fix upgrade-downgrade test setup and fix the init_db.sql Jul 18, 2023
…sql file for upgrade-downgrade tests to work

Signed-off-by: Manan Gupta <manan@planetscale.com>
…rsion

Signed-off-by: Manan Gupta <manan@planetscale.com>
@harshit-gangal harshit-gangal merged commit c15ecd0 into vitessio:release-16.0 Jul 19, 2023
112 checks passed
@harshit-gangal harshit-gangal deleted the fix-upgrade-downgrade-read-only branch July 19, 2023 08:30
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants