-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using UpdateShard Fields more. #1373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the topo.Server method does the work, same as UpdateShardFields. It also now supports ErrNoUpdateNeeded. Removing it from the topo.Impl interface, as it's not needed any more.
LGTM |
alainjobart
added a commit
that referenced
this pull request
Dec 7, 2015
Using UpdateShard Fields more.
dbussink
added a commit
that referenced
this pull request
Jan 30, 2023
* semantics: Use a BitSet (#11819) (#11837) * make sure planner works well with more than 64 tables Signed-off-by: Andres Taylor <andres@planetscale.com> * semantics: use an immutable bitset Signed-off-by: Vicent Marti <vmg@strn.cat> * bitset: add documentation Signed-off-by: Vicent Marti <vmg@strn.cat> * bitset: add license Signed-off-by: Vicent Marti <vmg@strn.cat> * use IsEmpty and NonEmpty more Signed-off-by: Andres Taylor <andres@planetscale.com> * rename file Signed-off-by: Andres Taylor <andres@planetscale.com> * bitset: better documentation Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com> * boostplan: use the new TableSet API Signed-off-by: Vicent Marti <vmg@strn.cat> * [planner] Better AST equality (#11867) (#1387) * [planner] Better AST equality (#11867) * make it possible to do deep comparisons with custom logic Signed-off-by: Andres Taylor <andres@planetscale.com> * use the new EqualS function to do deep semantic equality Signed-off-by: Andres Taylor <andres@planetscale.com> * re gen the asthelpergen integration test data Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update equal gen comment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test: add unit tests showing the new EqualsExpr functionality Signed-off-by: Andres Taylor <andres@planetscale.com> * [planner] use the semantic equality in more places Signed-off-by: Andres Taylor <andres@planetscale.com> * comments - update to reflect new code Signed-off-by: Andres Taylor <andres@planetscale.com> * small fixes around tests Signed-off-by: Andres Taylor <andres@planetscale.com> * update integration test build Signed-off-by: Andres Taylor <andres@planetscale.com> * use semantic equality for Anding together expressions Signed-off-by: Andres Taylor <andres@planetscale.com> * test: simplify test Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> * boostplan: use new AST equality helpers Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Vicent Marti <vmg@strn.cat> * Fix deprecated ioutil usage in custom backups (#1388) These are our internal implementations for backup so they won't get updated upstream to fix this deprecation, so we have to do it here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Vicent Marti <vmg@strn.cat> * Experiment boost queries on Gen4 (#1373) * watcher: add support for experiments Signed-off-by: Vicent Marti <vmg@strn.cat> * more logic around comparing results Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add engine primitive that can compare boost and gen4 results Signed-off-by: Andres Taylor <andres@planetscale.com> * link the gen4 vs boost comparison to the plan time in vtgate Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * refactor the utils comparison methods and add fail on error to boost experiments Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add an enum to experiments Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * rename experiments to querycomparison Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add topo rpc endpoint in vtboost and vtctld Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add vtctldclient command for setquerycomparisons Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * change fakeControllerClient to implement DRPCControllerServiceClient Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * self-review Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * run TryExecute async when failure mode is set to LOG Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * run TryStreamExecute async when failure mode is set to LOG Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Introduce a pflag file for boost Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix proto files Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix executor error Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * re gen proto Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * apply review suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Rename query comparison to Science Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Filter SetScience per cluster Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Simplify the set science in tests and optimize the use of vcursor in BoostCompare Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of context to BoostCompare Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove BackgroundVCursor Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * topo: simplify Signed-off-by: Vicent Marti <vmg@strn.cat> * use ctx.Background Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * gofmt Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * make proto Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * endtoend: fix test output Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Andres Taylor <andres@planetscale.com> * boost: Go 1.19 cleanups (#1403) * common: use Go 1.19 atomics Signed-off-by: Vicent Marti <vmg@strn.cat> * Fix go.mod Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> * add group by and original expressions (#1423) * add group by and original expressions Signed-off-by: Andres Taylor <andres@planetscale.com> * incorporator: allow disabling upquery generation Signed-off-by: Vicent Marti <vmg@strn.cat> * integration: remove unused test Signed-off-by: Vicent Marti <vmg@strn.cat> * don't rewrite colnames in the original query while planning upqueries Signed-off-by: Andres Taylor <andres@planetscale.com> * boostplan: add missing upquery rewrite Signed-off-by: Vicent Marti <vmg@strn.cat> * incorporator: revert optional upqueries Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Vicent Marti <vmg@strn.cat> * [planner] Schema information on the information_schema views (#11941) * add info_schema information Signed-off-by: Andres Taylor <andres@planetscale.com> * add SchemaInformation handling for info_schema tables Signed-off-by: Andres Taylor <andres@planetscale.com> * fix bad test query Signed-off-by: Andres Taylor <andres@planetscale.com> * add support for information_schema on mysql 5.7 Signed-off-by: Andres Taylor <andres@planetscale.com> * columns sorted just like mysql, and tests for 5.7 Signed-off-by: Andres Taylor <andres@planetscale.com> * test: skip test that should not run Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: FlorentP <35779988+frouioui@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michael-berlin @enisoc