Update Gateway to support tracking the status of its endpoints. #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Would it be possible to add a simple sanity check this works, in the vtgatev2 test for instance? Like just querying the status page, and making sure one or two entries are in there. Otherwise this is completely untested code... |
|
This is mainly for other gateway implementation for now. I will add test code for it. |
guoliang100
added a commit
that referenced
this pull request
Dec 11, 2015
Update Gateway to support tracking the status of its endpoints.
dbussink
added a commit
that referenced
this pull request
Jan 30, 2023
* gcsbackup: check for complete backups and support restarting (#1380) Changes the .StartBackup() method to do two things: 1. If there is already a MANIFEST return an error and refuse to start the backup. 2. If there is no MANIFEST clear all files to allow "restarting" the backup. This matches the recent changes made to kmsbackup plugin. * Online DDL: fix 'vtctlclient OnlineDDL' template queries (#11889) (#1383) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Implement total duration sketches in insights (#1324) * Implement total duration sketches in insights. Signed-off-by: Rafer Hazen <rafer@ralua.com> * Add new insights flags to end-to-end tests Signed-off-by: Rafer Hazen <rafer@ralua.com> * Update psevents dependency now that the sketches branch is merged Signed-off-by: Rafer Hazen <rafer@ralua.com> * go mod tidy Signed-off-by: Rafer Hazen <rafer@ralua.com> * Typo * autocomplete Signed-off-by: Rafer Hazen <rafer@ralua.com> * Fix comment Signed-off-by: Rafer Hazen <rafer@ralua.com> * DDSketch#observe -> #addSample Signed-off-by: Rafer Hazen <rafer@ralua.com> * CPU/memory optimizations Signed-off-by: Rafer Hazen <rafer@ralua.com> * Make uint options in setupOptions be *uint to match others Signed-off-by: Rafer Hazen <rafer@ralua.com> * Remove count and sum from DDSketch (since we already have these values) Signed-off-by: Rafer Hazen <rafer@ralua.com> * Remove DDSketch since all we need is a map Signed-off-by: Rafer Hazen <rafer@ralua.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> * resolved conflict (#1384) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> * boost: prepare for implementing midflow upqueries (#1377) * boost: prepare for implementing midflow upqueries Signed-off-by: Vicent Marti <vmg@strn.cat> * materialization: better error for this plan Signed-off-by: Vicent Marti <vmg@strn.cat> * boostplan: add missing file Signed-off-by: Vicent Marti <vmg@strn.cat> * ops_to_ast: disable upquery tests for now Signed-off-by: Vicent Marti <vmg@strn.cat> * Implement dummy commit migration logic This adds Commit() logic for a dummy migration so that we can combine it with the test incorporator to create a full commit cycle. This is needed for the linter logic we have in Singularity so we can ensure we can plan the full thing including materialization since there are error cases we only cover in the second part of the process. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove debugging statement Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Assign domain and local node indexes The logic in materialization expects these to be set to something that's not the invalid value, so let's set it to something more sensible. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> * boost planner: error on queries that don't use full group by (#1382) * added planner logic to handle columns outside the only_full_group_by limits Signed-off-by: Andres Taylor <andres@planetscale.com> * fixes to the new aggregation planning Signed-off-by: Andres Taylor <andres@planetscale.com> * add failing test Signed-off-by: Andres Taylor <andres@planetscale.com> * Remove unused bits Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Revert flownode changes for random aggregation Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Add test for no full group by Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> * Fix deprecated ioutil usage in custom backups (#1388) These are our internal implementations for backup so they won't get updated upstream to fix this deprecation, so we have to do it here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> * controller: implement dummyMigration on top of migration (#1390) Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Vicent Marti <vmg@strn.cat> * Fix flags output Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Rafer Hazen <rafer@ralua.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Amir Abushareb <yields@icloud.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Rafer Hazen <rafer@ralua.com> Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
dbussink
added a commit
that referenced
this pull request
Jan 30, 2023
* semantics: Use a BitSet (#11819) (#11837) * make sure planner works well with more than 64 tables Signed-off-by: Andres Taylor <andres@planetscale.com> * semantics: use an immutable bitset Signed-off-by: Vicent Marti <vmg@strn.cat> * bitset: add documentation Signed-off-by: Vicent Marti <vmg@strn.cat> * bitset: add license Signed-off-by: Vicent Marti <vmg@strn.cat> * use IsEmpty and NonEmpty more Signed-off-by: Andres Taylor <andres@planetscale.com> * rename file Signed-off-by: Andres Taylor <andres@planetscale.com> * bitset: better documentation Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com> * boostplan: use the new TableSet API Signed-off-by: Vicent Marti <vmg@strn.cat> * [planner] Better AST equality (#11867) (#1387) * [planner] Better AST equality (#11867) * make it possible to do deep comparisons with custom logic Signed-off-by: Andres Taylor <andres@planetscale.com> * use the new EqualS function to do deep semantic equality Signed-off-by: Andres Taylor <andres@planetscale.com> * re gen the asthelpergen integration test data Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update equal gen comment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test: add unit tests showing the new EqualsExpr functionality Signed-off-by: Andres Taylor <andres@planetscale.com> * [planner] use the semantic equality in more places Signed-off-by: Andres Taylor <andres@planetscale.com> * comments - update to reflect new code Signed-off-by: Andres Taylor <andres@planetscale.com> * small fixes around tests Signed-off-by: Andres Taylor <andres@planetscale.com> * update integration test build Signed-off-by: Andres Taylor <andres@planetscale.com> * use semantic equality for Anding together expressions Signed-off-by: Andres Taylor <andres@planetscale.com> * test: simplify test Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> * boostplan: use new AST equality helpers Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Vicent Marti <vmg@strn.cat> * Fix deprecated ioutil usage in custom backups (#1388) These are our internal implementations for backup so they won't get updated upstream to fix this deprecation, so we have to do it here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Vicent Marti <vmg@strn.cat> * Experiment boost queries on Gen4 (#1373) * watcher: add support for experiments Signed-off-by: Vicent Marti <vmg@strn.cat> * more logic around comparing results Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add engine primitive that can compare boost and gen4 results Signed-off-by: Andres Taylor <andres@planetscale.com> * link the gen4 vs boost comparison to the plan time in vtgate Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * refactor the utils comparison methods and add fail on error to boost experiments Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add an enum to experiments Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * rename experiments to querycomparison Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add topo rpc endpoint in vtboost and vtctld Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add vtctldclient command for setquerycomparisons Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * change fakeControllerClient to implement DRPCControllerServiceClient Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * self-review Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * run TryExecute async when failure mode is set to LOG Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * run TryStreamExecute async when failure mode is set to LOG Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Introduce a pflag file for boost Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix proto files Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix executor error Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * re gen proto Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * apply review suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Rename query comparison to Science Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Filter SetScience per cluster Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Simplify the set science in tests and optimize the use of vcursor in BoostCompare Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of context to BoostCompare Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove BackgroundVCursor Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * topo: simplify Signed-off-by: Vicent Marti <vmg@strn.cat> * use ctx.Background Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * gofmt Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * make proto Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * endtoend: fix test output Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Andres Taylor <andres@planetscale.com> * boost: Go 1.19 cleanups (#1403) * common: use Go 1.19 atomics Signed-off-by: Vicent Marti <vmg@strn.cat> * Fix go.mod Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> * add group by and original expressions (#1423) * add group by and original expressions Signed-off-by: Andres Taylor <andres@planetscale.com> * incorporator: allow disabling upquery generation Signed-off-by: Vicent Marti <vmg@strn.cat> * integration: remove unused test Signed-off-by: Vicent Marti <vmg@strn.cat> * don't rewrite colnames in the original query while planning upqueries Signed-off-by: Andres Taylor <andres@planetscale.com> * boostplan: add missing upquery rewrite Signed-off-by: Vicent Marti <vmg@strn.cat> * incorporator: revert optional upqueries Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Vicent Marti <vmg@strn.cat> * [planner] Schema information on the information_schema views (#11941) * add info_schema information Signed-off-by: Andres Taylor <andres@planetscale.com> * add SchemaInformation handling for info_schema tables Signed-off-by: Andres Taylor <andres@planetscale.com> * fix bad test query Signed-off-by: Andres Taylor <andres@planetscale.com> * add support for information_schema on mysql 5.7 Signed-off-by: Andres Taylor <andres@planetscale.com> * columns sorted just like mysql, and tests for 5.7 Signed-off-by: Andres Taylor <andres@planetscale.com> * test: skip test that should not run Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: FlorentP <35779988+frouioui@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alainjobart @sougou