vitessdriver: Set default values in OpenWithConfiguration() + fix db.Ping() comment. #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I confused sql.Open() with sql.Driver.Open(). The first one is the general Go interface which still requires db.Ping() to check if a connection works. Driver.Open() is not related to this at all. (It gets called when the Go sql package actually opens the connection e.g. when db.Ping() is called.)
…to one test using testcases. Added test that default values which are omitted from the JSON string, will be set correctly.
…r empty fields. Added respective unit test.
Otherwise tests will always be executed with "grpc" driver. This fails when a BSON RPC vtgate is used in the tests.
|
LGTM |
michael-berlin
added a commit
that referenced
this pull request
Dec 14, 2015
vitessdriver: Set default values in OpenWithConfiguration() + fix db.Ping() comment.
dbussink
added a commit
that referenced
this pull request
Jan 30, 2023
* gcsbackup: check for complete backups and support restarting (#1380) Changes the .StartBackup() method to do two things: 1. If there is already a MANIFEST return an error and refuse to start the backup. 2. If there is no MANIFEST clear all files to allow "restarting" the backup. This matches the recent changes made to kmsbackup plugin. * Online DDL: fix 'vtctlclient OnlineDDL' template queries (#11889) (#1383) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Implement total duration sketches in insights (#1324) * Implement total duration sketches in insights. Signed-off-by: Rafer Hazen <rafer@ralua.com> * Add new insights flags to end-to-end tests Signed-off-by: Rafer Hazen <rafer@ralua.com> * Update psevents dependency now that the sketches branch is merged Signed-off-by: Rafer Hazen <rafer@ralua.com> * go mod tidy Signed-off-by: Rafer Hazen <rafer@ralua.com> * Typo * autocomplete Signed-off-by: Rafer Hazen <rafer@ralua.com> * Fix comment Signed-off-by: Rafer Hazen <rafer@ralua.com> * DDSketch#observe -> #addSample Signed-off-by: Rafer Hazen <rafer@ralua.com> * CPU/memory optimizations Signed-off-by: Rafer Hazen <rafer@ralua.com> * Make uint options in setupOptions be *uint to match others Signed-off-by: Rafer Hazen <rafer@ralua.com> * Remove count and sum from DDSketch (since we already have these values) Signed-off-by: Rafer Hazen <rafer@ralua.com> * Remove DDSketch since all we need is a map Signed-off-by: Rafer Hazen <rafer@ralua.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> * resolved conflict (#1384) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> * boost: prepare for implementing midflow upqueries (#1377) * boost: prepare for implementing midflow upqueries Signed-off-by: Vicent Marti <vmg@strn.cat> * materialization: better error for this plan Signed-off-by: Vicent Marti <vmg@strn.cat> * boostplan: add missing file Signed-off-by: Vicent Marti <vmg@strn.cat> * ops_to_ast: disable upquery tests for now Signed-off-by: Vicent Marti <vmg@strn.cat> * Implement dummy commit migration logic This adds Commit() logic for a dummy migration so that we can combine it with the test incorporator to create a full commit cycle. This is needed for the linter logic we have in Singularity so we can ensure we can plan the full thing including materialization since there are error cases we only cover in the second part of the process. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove debugging statement Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Assign domain and local node indexes The logic in materialization expects these to be set to something that's not the invalid value, so let's set it to something more sensible. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> * boost planner: error on queries that don't use full group by (#1382) * added planner logic to handle columns outside the only_full_group_by limits Signed-off-by: Andres Taylor <andres@planetscale.com> * fixes to the new aggregation planning Signed-off-by: Andres Taylor <andres@planetscale.com> * add failing test Signed-off-by: Andres Taylor <andres@planetscale.com> * Remove unused bits Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Revert flownode changes for random aggregation Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Add test for no full group by Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> * Fix deprecated ioutil usage in custom backups (#1388) These are our internal implementations for backup so they won't get updated upstream to fix this deprecation, so we have to do it here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> * controller: implement dummyMigration on top of migration (#1390) Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Vicent Marti <vmg@strn.cat> * Fix flags output Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Rafer Hazen <rafer@ralua.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Amir Abushareb <yields@icloud.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Rafer Hazen <rafer@ralua.com> Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sougou @alainjobart
This fixes issues I ran into when I used the driver myself :)