Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with WAIT_FOR_EXECUTED_GTID_SET (#14612) #14619

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[release-17.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with WAIT_FOR_EXECUTED_GTID_SET (#14612) #14619

merged 1 commit into from
Nov 28, 2023

Conversation

shlomi-noach
Copy link
Contributor

Description

This is a backport of #14612

@shlomi-noach
Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with `WAIT_FOR_EXE…
d90e030 
…CUTED_GTID_SET` (vitessio#14612)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach requested a review from a team November 27, 2023 14:51
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 27, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v17.0.5 milestone Nov 27, 2023
@shlomi-noach shlomi-noach mentioned this pull request Nov 27, 2023
Merged
4 tasks
@shlomi-noach shlomi-noach added Component: General Changes throughout the code base and removed Component: General Changes throughout the code base labels Nov 27, 2023
@shlomi-noach shlomi-noach merged commit 29d3784 into vitessio:release-17.0 Nov 28, 2023
115 of 116 checks passed
@shlomi-noach shlomi-noach deleted the backport-14612-to-release-17.0 branch November 28, 2023 05:46
@deepthi deepthi mentioned this pull request Dec 9, 2023
Merged
deepthi added a commit to planetscale/vitess that referenced this pull request Dec 9, 2023
@deepthi
Revert "[release-17.0] Replace use of `WAIT_UNTIL_SQL_THREAD_AFTER_GT…
4715e3a 
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (vitessio#14612) (vitessio#14619)"

This reverts commit 29d3784.

Signed-off-by: deepthi <deepthi@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Backport This is a backport Component: TabletManager Type: Internal Cleanup
Projects
None yet
Milestone
v17.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@shlomi-noach @dbussink @frouioui @deepthi