Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[release-17.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with WAIT_FOR_EXECUTED_GTID_SET (#14612)" #14744

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Revert "[release-17.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with WAIT_FOR_EXECUTED_GTID_SET (#14612)" #14744

merged 1 commit into from
Dec 11, 2023

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Dec 9, 2023

Reverts #14619

because it causes #14738

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 9, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 9, 2023
@deepthi deepthi mentioned this pull request Dec 9, 2023
Closed
4 tasks
@github-actions github-actions bot added this to the v17.0.5 milestone Dec 9, 2023
@rohit-nayak-ps rohit-nayak-ps added Type: Bug Component: Cluster management and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 9, 2023
@deepthi
Revert "[release-17.0] Replace use of `WAIT_UNTIL_SQL_THREAD_AFTER_GT…
4715e3a 
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (#14612) (#14619)"

This reverts commit 29d3784.

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi force-pushed the revert-14619-backport-14612-to-release-17.0 branch from 5ae5412 to 4715e3a Compare December 9, 2023 20:31
GuptaManan100
GuptaManan100 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuptaManan100 GuptaManan100 merged commit 4cb4856 into release-17.0 Dec 11, 2023
222 of 223 checks passed
@GuptaManan100 GuptaManan100 deleted the revert-14619-backport-14612-to-release-17.0 branch December 11, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@mattlord mattlord mattlord approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Cluster management Type: Bug
Projects
None yet
Milestone
v17.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@deepthi @mattlord @GuptaManan100 @rohit-nayak-ps