Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Upgrade downgrade tests #14782

Merged
merged 9 commits into from
Dec 20, 2023
Merged

Refactor Upgrade downgrade tests #14782

merged 9 commits into from
Dec 20, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR makes the following changes -

  1. It refactors the upgrade downgrade tests to use a single job to run instead of having 2 jobs since they then show up twice in the CI run output.
  2. Refactor the upgrade downgrade test names to have Upgrade Downgrade Testing as a suffix instead of a prefix so that we see the type of upgrade downgrade test first in the CI output.
  3. Adds a test for testing time function with precision specified. This is the same test added in Fix accepting bind variables in time related function calls. #14763, being copied over.
  4. Run all the sub-packages of tests in vtgate/queries as part of the Query Serving (Queries) upgrade downgrade testing.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
test: add all subpackages in vtgate/queries to upgrade downgrade tests
a552531 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: add a test for time function calls with precision
bc7636e 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: rename upgrade downgrade tests to have upgrade downgrade as a s…
a10d51a 
…uffix

Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 14, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 14, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 14, 2023
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 14, 2023
@GuptaManan100
refactor backups e2e test to only use a single job
41ac243 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
refactor other upgrade downgrade tests to only use a single job
17ade29 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
minor fix to workflow file
26731bd 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: fix upgrade downgrade tests
320295e 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Merge remote-tracking branch 'upstream/main' into enable-upgrade-down…
b9e48a5 
…grade

Signed-off-by: Manan Gupta <manan@planetscale.com>
This was referenced Dec 18, 2023
Open
Open
Open
@GuptaManan100 GuptaManan100 marked this pull request as ready for review December 19, 2023 09:03
@GuptaManan100
Merge remote-tracking branch 'upstream/main' into enable-upgrade-down…
be71a16 
…grade

Signed-off-by: Manan Gupta <manan@planetscale.com>
mattlord
mattlord approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GuptaManan100 !

@GuptaManan100 GuptaManan100 merged commit ff62da9 into vitessio:main Dec 20, 2023
104 checks passed
@GuptaManan100 GuptaManan100 deleted the enable-upgrade-downgrade branch December 20, 2023 03:51
This was referenced Dec 20, 2023
Merged
Merged
Merged
GuptaManan100 added a commit that referenced this pull request Dec 21, 2023
@GuptaManan100
Refactor Upgrade downgrade tests (#14782)
ad577f2 
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100 added a commit that referenced this pull request Dec 21, 2023
@GuptaManan100
Refactor Upgrade downgrade tests (#14782)
ad3317a 
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100 added a commit that referenced this pull request Dec 21, 2023
@GuptaManan100
Refactor Upgrade downgrade tests (#14782)
268913d 
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100 added a commit that referenced this pull request Dec 27, 2023
@vitess-bot @GuptaManan100
[release-18.0] Refactor Upgrade downgrade tests (#14782) (#14832)
142a074 
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
GuptaManan100 added a commit that referenced this pull request Dec 27, 2023
@vitess-bot @GuptaManan100
[release-17.0] Refactor Upgrade downgrade tests (#14782) (#14831)
6e73e2e 
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
GuptaManan100 added a commit that referenced this pull request Dec 27, 2023
@vitess-bot @GuptaManan100
[release-16.0] Refactor Upgrade downgrade tests (#14782) (#14830)
e45d0cf 
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Jan 24, 2024
@GuptaManan100 @ejortegau
Refactor Upgrade downgrade tests (vitessio#14782)
805fd9a 
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com>
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Mar 12, 2024
@planetscale-actions-bot @GuptaManan100
[latest-17.0](vitessio#4001): CherryPick(vitessio#14782): Refactor Up…
1278503 
…grade downgrade tests (vitessio#4031)

* CherryPick(vitessio#14782): Refactor Upgrade downgrade tests (vitessio#4001)

* Refactor Upgrade downgrade tests (vitessio#14782)

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix test expectations given that a lot of the fixes have been backported in private

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix test expectations

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>

* test: fix upgrade downgrade tests

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix tests again...

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
frouioui pushed a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
@planetscale-actions-bot @GuptaManan100
[latest-18.0](vitessio#4001): CherryPick(vitessio#14782): Refactor Up…
ec50688 
…grade downgrade tests (vitessio#4032)

* CherryPick(vitessio#14782): Refactor Upgrade downgrade tests (vitessio#4001)

* Refactor Upgrade downgrade tests (vitessio#14782)

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix test expectations given that a lot of the fixes have been backported in private

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix test expectations

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>

* test: fix upgrade tests

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix tests again

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix tests again....

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot @GuptaManan100
CherryPick(#14782): Refactor Upgrade downgrade tests (#4001)
ae52df1 
* Refactor Upgrade downgrade tests (#14782)

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix test expectations given that a lot of the fixes have been backported in private

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix test expectations

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@mattlord mattlord mattlord approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Internal Cleanup Type: Testing
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @mattlord @frouioui