vtbench: add initial version of a vitess benchmarking tool #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a simple benchmark tool that is capable of running queries using either mysql or grpc protocol to a vtgate, or by grpc straight to a vttablet. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
|
Nice work @demmer! This could also be the 1st building block to run bench tests for each PR and catch unexpected regressions |
rafael
approved these changes
Jun 18, 2018
| case "grpc-vtgate": | ||
| clientProto = vtbench.GRPCVtgate | ||
| case "grpc-vttablet": | ||
| clientProto = vtbench.GRPCVttablet |
There was a problem hiding this comment.
Is this to run the test directly against the tablet? We should include it in the protocol list doc string.
go/vtbench/vtbench.go
Outdated
| b.wg.Done() | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
Should we remove this commented code?
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
|
@sougou I addressed Rafael's comments and added a usage example. Can you let me know if this is what you had in mind before I merge? |
sougou
reviewed
Jun 22, 2018
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
…grade downgrade tests (vitessio#4032) * CherryPick(vitessio#14782): Refactor Upgrade downgrade tests (vitessio#4001) * Refactor Upgrade downgrade tests (vitessio#14782) Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix test expectations given that a lot of the fixes have been backported in private Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix test expectations Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com> * test: fix upgrade tests Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix tests again Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix tests again.... Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a simple benchmark tool that is capable of running queries using either mysql or grpc protocol to a vtgate, or by grpc straight to a vttablet.
Motivation
Although plenty of off the shelf benchmarking tools existed, I wanted one where I was able to control the parallelism and make apples to apples comparisons between mysql / grpc vtgate / grpc vttablet.