ignore mysql-specific comment statements #3576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #3520
Ignore
/*! mysql-specific */
and/*!50708 mysql-version-specific */
comments.I'm not sure if it's a good idea. Instead of stripping leading comments,
in case it's
/*! ... */
we now don't strip it, and consider it a new StmtComment statement type.(Not sure if that should be added to ast.go . I didn't.)
I assumed this kind of comment was the only thing in the query,
so if there's something like
"/*! ... */ select ..."
it wouldn't work.The handleComment in executor.go basically does nothing, returning
&sqltypes.Result{}