Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore mysql-specific comment statements #3576

Merged
merged 1 commit into from
Jan 23, 2018
Merged

ignore mysql-specific comment statements #3576

merged 1 commit into from
Jan 23, 2018

Commits on Jan 23, 2018

  1. ignore /*! mysql-specific */ comment statements 

    This is related to #3520

Also ignore /*!50708 mysql-version-specific */ comments.

I'm not sure if it's a good idea. Instead of stripping leading comments,
in case it's /*! ... */ we don't strip it, and consider it a new StmtComment statement type.
(Not sure if that should be added to ast.go . I didn't.)
I assumed this kind of comment was the only thing in the query,
so if there's something like "/*! ... */ select ..." it wouldn't work.
The handleComment in executor.go basically does nothing, returning &sqltypes.Result{}
    Scott Lanning committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    cc06faf View commit details
    Browse the repository at this point in the history