Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vterrors to store stack traces #4556

Merged
merged 2 commits into from
Mar 3, 2019
Merged

Use vterrors to store stack traces #4556

merged 2 commits into from
Mar 3, 2019

Conversation

systay
Copy link
Collaborator

@systay systay commented Jan 28, 2019 •
edited
Loading

No description provided.

@systay systay requested a review from sougou as a code owner January 28, 2019 13:30
@systay systay force-pushed the errors branch 4 times, most recently from cb6d6d6 to 5d1773f Compare January 29, 2019 09:31
@systay systay force-pushed the errors branch 5 times, most recently from a86a398 to 63ddfeb Compare February 25, 2019 17:03
@systay
Errors clean up
7fb5dce 
* Use vterrors in few places
* Make stack trace display the default
* More unit testing around error handling

Signed-off-by: Andres Taylor <antaylor@squareup.com>
@systay
Use vterrors in the mysql package
c6cae69 
Signed-off-by: Andres Taylor <antaylor@squareup.com>
deepthi
deepthi approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'm not sure I agree with using RPC error codes everywhere, but vterrors seems to require that, so that's fine.
Upon discussion with @sougou, learned that the error codes are designed to be generic, not just for RPCs.

@deepthi deepthi merged commit 6585831 into vitessio:master Mar 3, 2019
@demmer demmer mentioned this pull request Apr 19, 2019
Merged
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot
cherry pick of 15294 (#4556)
5d22201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@systay @deepthi