make the logging of stacks in errors an opt-in behavior #4826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a -logerrstacks flag to the vterrors module to make the error logging of stack traces opt-in.
Details
The behavior added in #4556 to embed stack traces in all vterrors makes the error output much more verbose.
Since some users prefer the earlier behavior in which only panic level errors included stack traces, add a flag to the vterrors module to make the stack trace logging opt-in.
CC: @systay