Create a mutable list of insert keys so verify works. #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpawliszyn
force-pushed
the
mikepaw.fix-insert-ignore
branch
2 times, most recently
from
050e729
to
6f810fb
Compare
mpawliszyn
force-pushed
the
mikepaw.fix-insert-ignore
branch
from
6f810fb
to
b0855dc
Compare
This reverts commit 8f522d1. Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
Instead of getting everything sorting the same way, it is much easier to save a copy that we use to validate lookup table inserts. Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
mpawliszyn
force-pushed
the
mikepaw.fix-insert-ignore
branch
from
b0855dc
to
195385b
Compare
|
Can you take a look at #4965. Instead of dealing with sorted values from the callers, it's better that the callee sort a copy of the input values. This way, no one is externally affected. I've copied your tests into the new PR to show that it works as intended. |
|
Closed in favor of #4965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.