vindexes: alt approach for lookup sorted inserts #4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like too many callers are affected if the passed in values are sorted by the `Create` function. Instead of changing all the call sites, it's better that `Create` sorts a copy of the values and leave the external behavior unchanged. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
mpawliszyn
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like too many callers are affected if the passed in values
are sorted by the
Createfunction. Instead of changing allthe call sites, it's better that
Createsorts a copy of thevalues and leave the external behavior unchanged.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com