Add action to create deb/rpm packages #4963
Conversation
Signed-off-by: John Watson <johnw@planetscale.com>
dctrwatson
requested review from
derekperkins,
dkhenry and
sougou
as code owners
docker/packaging/package_vitess.sh
Outdated
| /vt/bin/vtctld | ||
| /vt/bin/vtgate | ||
| /vt/bin/vttablet | ||
| /vt/bin/vtworker |
docker/packaging/etc_default_vitess
Outdated
| VTTOP="$VTROOT/src/vitess.io/vitess" | ||
| GOTOP="$VTTOP/go" | ||
| GOBIN="$VTROOT/bin" | ||
| GOPATH="$VTROOT" |
There was a problem hiding this comment.
I don't know if we should have golang variables in the packagesa. I think in a perfect world you don't need to have any go installed to install vitess
There was a problem hiding this comment.
It's not for Go itself, but in https://github.com/vitessio/vitess/blob/master/docker/lite/Dockerfile#L38 this comment makes them sound necessary.
# Set up Vitess environment (just enough to run pre-built Go binaries)
| --directories "/vt/bin" \ | ||
| --directories "/vt/src" \ | ||
| --inputs "${inputs_file}" \ | ||
| --before-install "/vt/packaging/preinstall.sh" \ |
There was a problem hiding this comment.
For all of these can we move from Vitess specific directories to the standard unix directories.
config=/etc/vitess
bin=$PREFIX/bin
src=$PREFIX/src
lib=$PREFIX/lib/vitess/
and have all the web resource go into the lib folder
There was a problem hiding this comment.
Easy enough to do. I was just mimicking the lite docker image.
Signed-off-by: John Watson <johnw@planetscale.com>
Signed-off-by: John Watson <johnw@planetscale.com>
Signed-off-by: John Watson <johnw@planetscale.com>
|
@dkhenry Is this ready to merge? |
Partially addresses #4955
Signed-off-by: John Watson johnw@planetscale.com