Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages: add support for topics that route inserts to multiple subscriber message tables #5011

Merged
merged 6 commits into from
Aug 17, 2019

Conversation

derekperkins
Copy link
Member

@derekperkins derekperkins commented Jul 20, 2019

This is an alternative approach to #4956 to solve #4940. Instead of having topics separate from tables, it adds topics as pseudo tables.

@derekperkins derekperkins force-pushed the message-topics-pseudo-table branch 2 times, most recently from 07c9490 to c7841d7 Compare July 21, 2019 20:04
@derekperkins derekperkins changed the title messages: use tables for topics WIP messages: use tables for topics Jul 21, 2019
@derekperkins derekperkins force-pushed the message-topics-pseudo-table branch 2 times, most recently from dd4f5b8 to d68498e Compare July 26, 2019 04:19
@derekperkins derekperkins changed the title WIP messages: use tables for topics messages: add support for topics that route inserts to multiple subscriber message tables Jul 26, 2019
@derekperkins
Copy link
Member Author

@sougou this is ready for review when you have time

go/vt/vttablet/tabletserver/schema/engine.go Show resolved Hide resolved
go/vt/vttablet/tabletserver/schema/engine.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletserver/schema/engine.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletserver/tabletserver.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I've suggested some minor adjustments.

go/vt/vttablet/tabletserver/schema/engine.go Show resolved Hide resolved
go/vt/vttablet/tabletserver/schema/load_table.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletserver/tabletserver.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletserver/tabletserver.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletserver/planbuilder/dml.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletserver/tabletserver.go Outdated Show resolved Hide resolved
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Signed-off-by: Derek Perkins <derek@derekperkins.com>
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work. The whole PR reads very well. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants