This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Slack vitess 2019.08.26.r0 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: dcadevil <dcadevil@126.com>
Since the vtgate executor accepts arbitrary sql identifiers as the type value for `show` statements, remove vitess-specific keywords from the grammar for things like `vitess_keyspaces`, `vitess_shards`, and more. Along the way, add support for `show keyspaces` and make sure to lowercase the show target. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
…s-prepare Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Toliver Jue <toliver@planetscale.com>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
…tiglabs-prepare Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
vreplication: bug: make row streaming more robust
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
…n-standard-keywords-from-show Remove non standard keywords from show
- Fixed TestOrderedAggregateMergeFail in ordered_aggregate_test.go to return proper value for expressions such as "b + 1" Signed-off-by: Rasika Kale <rasika@planetscale.com>
… avoid runtime errors Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
routing rules: handle corner case in delete
Signed-off-by: hwdef <hwdef97@gmail.com>
Signed-off-by: hwdef <hwdef97@gmail.com>
Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
fix spelling mistake
Cleanup: fix some typos in code comment
Empty results should return a count of 0 but a sum of null.
fix typos in vtbackup.go
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
Signed-off-by: Rasika Kale <rasika@planetscale.com>
v3: support overlapping multi-column vindexes
- Deleted Subtract() and Multiply() and other functions not related to Add() Signed-off-by: Rasika Kale <rasika@planetscale.com>
Addition expression implementation
healthcheck after backup should be run only for offline backups
|
LGTM |
rafael
approved these changes
Sep 12, 2019
setassociative
approved these changes
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR merges the latest upstream from vitessio/vitess to our fork. This is mainly to pull in this bug fix for xtrabackup (vitessio#5066)
Testing
• Jenkins build https://jenkins.tinyspeck.com/job/slack-vitess/359/
• Let the build bake in dev for about a week now and took manual backups -- things look fine
Jira
https://jira.tinyspeck.com/browse/VITESS-424
Changes
To view all the commits in this change, see commits.txt
$ git log e983049e5c3349792c4f3325f1cccdca3d987276...9bb5735a88842b8f237baf5c41943d4c5fd1a69d --name-only > commits.txtSlack changes:
vitessio/vitess#4384 remove unneeded vitess-specific keywords used for show statements
Notable non-test changes:
vitessio/vitess#3862 Add support for the MySQL prepare command protocol
vitessio/vitess#4996 v3: support overlapping multi-column vindexes
vitessio/vitess#4936 vtclient: Add sequential id generation and throttling
vitessio/vitess#5072 Addition expression implementation
vitessio/vitess#5040 Java Client: add VStream method to the
VTGateConnectionvitessio/vitess#5042 Allow start local cluster using a provided tablet host name
vitessio/vitess#4981 VReplication based traffic migrater
vitessio/vitess#5048 vreplication: clean-up copy_state correctly
vitessio/vitess#5047 Update vendored GCS client version
vitessio/vitess#5054 Add ability to process vschema migrations during vttestserver startup
vitessio/vitess#4987 Add initial support for capabilities
vitessio/vitess#5066 tablet should stay healthy while running xtrabackup
vitessio/vitess#5065 xtrabackup: Better support for large datasets
vitessio/vitess#5071 vtbackup: Don't enforce timeouts.
vitessio/vitess#5064 migrater: resharding_journal: participants change
vitessio/vitess#5094 Allow adding autoincrement column via "ALTER VSCHEMA..." statement
vitessio/vitess#5093 vreplication: fix character set issue
vitessio/vitess#5097 Make sure to handle COUNT and SUM with DISTINCT columns with empty input
vitessio/vitess#5011 messages: add support for topics that route inserts to multiple subscriber message tables
vitessio/vitess#5017 Updating to golang 1.12
vitessio/vitess#5129 healthcheck after backup should be run only for offline backups
From the code changes, some that are worth a closer look:
vitessio/vitess#5066 tablet should stay healthy while running xtrabackup. this is an important bug fix for us as we move to using xtrabackup.
vitessio/vitess#5071 vtbackup: Don't enforce timeouts. Now, it will keep retrying forever.
vitessio/vitess#5065 xtrabackup: Better support for large datasets.