Allow adding autoincrement column via "ALTER VSCHEMA..." statement #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karel Alfonso Sague <kalfonso@squareup.com>
kalfonso
force-pushed
the
kalfonso.190814-alter-vschema-add-autoinc
branch
from
10dbb6b
to
c031bd6
Compare
tirsen
approved these changes
Aug 15, 2019
| @@ -981,6 +981,8 @@ var ( | |||
| input: "alter vschema add table a", | |||
| }, { | |||
| input: "alter vschema add sequence a_seq", | |||
| }, { | |||
| input: "alter vschema on a add auto_increment id using a_seq", | |||
| @@ -1357,6 +1357,17 @@ alter_statement: | |||
| { | |||
| $$ = &DDL{Action: AddSequenceStr, Table: $5} | |||
| } | |||
| | ALTER VSCHEMA ON table_name ADD AUTO_INCREMENT sql_id USING table_name | |||
There was a problem hiding this comment.
Does “table_name” support keyspace prefix? Generally the sequence is in a different keyspace.
There was a problem hiding this comment.
yes, it accepts a qualifier which would be the keyspace in this case
sougou
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karel Alfonso Sague kalfonso@squareup.com