Slack vitess 2019.08.26.r0 #137

Signed-off-by: dcadevil <dcadevil@126.com>

Since the vtgate executor accepts arbitrary sql identifiers as the type value for `show` statements, remove vitess-specific keywords from the grammar for things like `vitess_keyspaces`, `vitess_shards`, and more. Along the way, add support for `show keyspaces` and make sure to lowercase the show target. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

…s-prepare Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Toliver Jue <toliver@planetscale.com>

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

…tiglabs-prepare Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

… error Changed tests TestAdd and TestCastFromNumeric_in arithmetic_test.go to return value output instead of error Signed-off-by: Rasika Kale <rasika@planetscale.com>

… and comments Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Paul Hemberger <phemberger@hubspot.com>

Signed-off-by: Rasika Kale <rasika@planetscale.com>

This helps fix a name resolution problem when initializing the tablet. If flag "tablet_hostname" is not provided it will be derived from the OS' hostname. The way it is implemented there is not guarantee that ```net.LookupHost(os.HostName())``` will return a valid IP for certain local env dns configs, i.e, in Mac OS X, hostname can be configured using the system's resolver which is not used by ```net.LookupHost``` Reference: init_tablet.go:151 Signed-off-by: Karel Alfonso Sague <kalfonso@squareup.com>

This removes the docs and images known to be in the website repo. Design documents are left untouched. Signed-off-by: Morgan Tocker <tocker@gmail.com>

Remove docs now hosted in vitessio/website

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

…server-localhost Allow start local cluster using a provided tablet host name

Java Client: add VStream method to the `VTGateConnection`

JSON String length computation: docs and unit tests

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

Since we don't support multiple source or target keyspaces, the uid parameters can be simplified to only have shards as keys, and there will be a separate targetKeyspace parameter that applies to all shards. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

Specifying shards and uids wasn't user-friendly. Specifying workflow names should better. However, it will be the user's responsibilty to keep them unique. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

VReplication based traffic migrater

* On delete of a row in _vt.vreplication, we should also cleanup the copy_state table, because it may have related rows. * Made workflow into a flag, but mandatory. Otherwise the number of unnamed arguments are too many and command becomes unreadable. * Added ability to read from _vt.copy_state using VReplicaionExec. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

Legacy mode vreplication will not create copy_state. So, we have to ignore the table not found error when deleting from copy_state. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

* Update GCS client version. Signed-off-by: Anthony Yeh <enisoc@planetscale.com> * restore: Add more detail to errors during file copy. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

I don't see any reason this was disabled so I assume it was checked in by accident. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

It seems that the base distro now includes mariadb 10.1, which means the package names conflict and it was getting stuck after installing some dependencies at 10.1 and others at 10.3. These package names seem to work to force it to use 10.3. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

Signed-off-by: John Watson <johnw@planetscale.com>

If the latest backup is incomplete, we should ignore it and take another one. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

Signed-off-by: Alex Charis <acharis@hubspot.com>

Signed-off-by: ethan <guangming.wang@daocloud.io>

add a testcase to binlog_event_json_test

…Rules-file-flag Fix ApplyRoutingRules -rules_file flag

test.go: Re-enable clean-up of docker test dirs.

cleanup: correct logging message

…ting during catchup phase of vreplication based resharding, add test case Signed-off-by: deepthi <deepthi@planetscale.com>

…lar to mySQL - Added possible tests for Addition function within arithmetic_test.go Signed-off-by: Rasika Kale <rasika@planetscale.com>

This allows the xtrabackup engine to be used. The image size has increased from 700MB to 750MB. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

Signed-off-by: Karel Alfonso Sague <kalfonso@squareup.com>

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

vtbackup: Only consider complete backups when looking for latest backup.

docker: Add XtraBackup to vitess/lite.

* Add initial support for capabilities This eliminates the need to set MYSQL_FLAVOR Signed-off-by: Morgan Tocker <tocker@gmail.com> * Removed MYSQL_FLAVOR variable precedence It will cause backwards compatibility problems, since many users set "MySQL56" for any MySQL system. Signed-off-by: Morgan Tocker <tocker@gmail.com> * Address PR feedback (WIP) Signed-off-by: Morgan Tocker <tocker@gmail.com> * Fixed mysql_safe to not use capabilitities Reverted small changes to configs Signed-off-by: Morgan Tocker <tocker@gmail.com> * fix version detection Signed-off-by: Morgan Tocker <tocker@gmail.com> * Fix style, re-add EXTRA_MY_CNF from review Signed-off-by: Morgan Tocker <tocker@gmail.com> * Address review feedback Signed-off-by: Morgan Tocker <tocker@gmail.com> * address remaining feedback Signed-off-by: Morgan Tocker <tocker@gmail.com> * Remove rogue added space Signed-off-by: Morgan Tocker <tocker@gmail.com> * Address PR feedback Signed-off-by: Morgan Tocker <tocker@gmail.com> * Address PR feedback Signed-off-by: Morgan Tocker <tocker@gmail.com> * Fix broken test Signed-off-by: Morgan Tocker <tocker@gmail.com> * Fixed tests Signed-off-by: Morgan Tocker <tocker@gmail.com> * Addressed PR feedback Added tests for version detection Signed-off-by: Morgan Tocker <tocker@gmail.com> * update copyright Signed-off-by: Morgan Tocker <tocker@gmail.com> * Remove unset MYSQL_FLAVOR I thought about this: it's a bad idea. It means that if there was a test that created 2 mysqld's, the usage would not be repeatable/idempotent. Signed-off-by: Morgan Tocker <tocker@gmail.com> * Make sure error is caught. Signed-off-by: Morgan Tocker <tocker@gmail.com> * Address PR Feedback Signed-off-by: Morgan Tocker <tocker@gmail.com>

…-state vreplication: clean-up copy_state correctly

Make all sources as participants. It's not worth doing exact computations in this case. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

…ents tablet from updating its replication lag Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: deepthi <deepthi@planetscale.com>

This is needed for long-running backups so that the xtrabackup process doesn't block after the write buffer fills up. It's also nice for checking in on progress during a long upload. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

There are now a larger set of required templates because we have auto-included files for every minor version (e.g. 5.6 vs 5.7). Just include everything instead of trying to pick and choose. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

…not get affacted Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

- In the process of implenting subtraction and multiplication function (marked within comments) Signed-off-by: Rasika Kale <rasika@planetscale.com>

Add Support for Prepared Statements

Direct write didn't use Infof() so there was no timestamp. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

To avoid requiring 2x disk space upon restore. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

…r online backup is running Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

xtrabackup: Better support for large datasets

…server-alter-vschema Add ability to process vschema migrations during vttestserver startup

Signed-off-by: czm <zhongming.chang@daocloud.io>

These have done more harm than good. If a backup has been going for a while, giving up and starting over from scratch is pretty much never going to help. We should just keep trying and have a system that alerts a human if it's taking longer than expected. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

fix wrong spells in acl.go

cleanup: word correction in tx_serializer.go

The plan is to remove python dependencies, so this makes the first step of not requiring it for bootstrap. The goal is that a user can do this: BUILD_PYTHON=0 ./bootstrap.sh source dev.env make ./tools/unit_test_runner.sh This only runs unit tests, but in future Go-based end-to-end testing is planned. Signed-off-by: Morgan Tocker <tocker@gmail.com>

Signed-off-by: Morgan Tocker <tocker@gmail.com>

…nless Gate Python and Java dependencies

package/worker: misspelled word in html template correction

migrater: resharding_journal: participants change

fix duplicate key error during resharding

…se needs to be updated to conform to that Signed-off-by: deepthi <deepthi@planetscale.com>

Fix failing test in CI after merging vitessio#5057

Signed-off-by: czm <zhongming.chang@daocloud.io>

* Fix UpdateCellsAlias. It should allow updates to an alias that overlap with the previous value of that same alias, since the old value is being replaced. Signed-off-by: Anthony Yeh <enisoc@planetscale.com> * Refactor overlappingAlias to validateAlias. To make it more clear which outcome is good and which is bad. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

Signed-off-by: Morgan Tocker <tocker@gmail.com>

- Deleted unnecessary comments - Fixed whitespace Signed-off-by: Rasika Kale <rasika@planetscale.com>

- Made rk-add-expression only for addition function Signed-off-by: Rasika Kale <rasika@planetscale.com>

…e, rather than value or error Signed-off-by: Rasika Kale <rasika@planetscale.com>

…ENCE TABLE statement Signed-off-by: Karel Alfonso Sague <kalfonso@squareup.com>

Signed-off-by: deepthi <deepthi@planetscale.com>

Move git hooks to start of bootstrap

fix wrong spells in tablet.go

…vschema-add-sequence-table Allow adding sequence table to the vschema via ALTER VSCHEMA ADD SEQU…

The latin1 character set performs some conversion, which was not our previous understanding. This changes vreplication to use binary character set instead, which is more faithful about not converting the bits in the database. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

also fix its corresponding test file typos Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>

Signed-off-by: Karel Alfonso Sague <kalfonso@squareup.com>

Signed-off-by: czm <zhongming.chang@daocloud.io>

Signed-off-by: Andres Taylor <antaylor@squareup.com>

Merged prepared statement code changes did not take into account staticcheck warnings. This PR addresses those warnings. Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

Signed-off-by: Andres Taylor <antaylor@squareup.com>

fix wrong spells in opentsdb.go

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

… to protect all access to _isBackupRunning and the stats variable Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

Address staticcheck warnings in prepared statement

tablet should stay healthy while running xtrabackup

* Auto-detect engine when restoring backups Signed-off-by: Anthony Yeh <enisoc@planetscale.com> * Add FinishedTime to MANIFEST. Signed-off-by: Anthony Yeh <enisoc@planetscale.com> * Store stream mode in xtrabackup MANIFEST. Signed-off-by: Anthony Yeh <enisoc@planetscale.com> * Address review comments. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>

Signed-off-by: czm <zhongming.chang@daocloud.io>

vreplication: fix character set issue

Signed-off-by: Morgan Tocker <tocker@gmail.com>

fix wrong spells in slave_connection.go

…vschema-add-autoinc Allow adding autoincrement column via "ALTER VSCHEMA..." statement

keyspace.go: cleanup typo in error message

…pabilities Signed-off-by: Morgan Tocker <tocker@gmail.com>

Signed-off-by: Morgan Tocker <tocker@gmail.com>

…h-empty-input Make sure to handle COUNT and SUM with DISTINCT columns with empty input

Signed-off-by: Derek Perkins <derek@derekperkins.com>

Signed-off-by: Morgan Tocker <tocker@gmail.com>

Signed-off-by: czm <zhongming.chang@daocloud.io>

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>

messages: add support for topics that route inserts to multiple subscriber message tables

cleanup: fix typos in mysql/client.go

fix wrong spells in vtprocess.go

…bilities Cleanup from capabilities PR

Signed-off-by: czm <zhongming.chang@daocloud.io>

Signed-off-by: Toliver Jue <toliver@planetscale.com>

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>

cleanup: engine/insert.go comment fix typo

fix mis-spelling in txlogz.go

During production testing, we found that there are possibilities that a table lock never gets released when row streaming is requested. We most likely suspect that a grpc send hangs, which keeps the table locked, when eventually causes replication to stall and subsequent row streaming requests to hang. This change refactors the code to make sure that we unlock a table as soon as streaming has started. The previous code unlocked the table only after sending the field info. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

Signed-off-by: Derek Perkins <derek@derekperkins.com>

helm: delete mysql.sock.lock in init container

Signed-off-by: 常仲民@DaoCloud <zhongming.chang@daocloud.io>

Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>

Updating to golang 1.12

vtclient: Add sequential id generation and throttling

Signed-off-by: Rasika Kale <rasika@planetscale.com>

vreplication: bug: make row streaming more robust

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

…n-standard-keywords-from-show Remove non standard keywords from show

- Fixed TestOrderedAggregateMergeFail in ordered_aggregate_test.go to return proper value for expressions such as "b + 1" Signed-off-by: Rasika Kale <rasika@planetscale.com>

… avoid runtime errors Signed-off-by: Rasika Kale <rasika@planetscale.com>

Signed-off-by: Rasika Kale <rasika@planetscale.com>

routing rules: handle corner case in delete

Signed-off-by: hwdef <hwdef97@gmail.com>

Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>

Signed-off-by: Rasika Kale <rasika@planetscale.com>

Signed-off-by: deepthi <deepthi@planetscale.com>

fix spelling mistake

Cleanup: fix some typos in code comment

Empty results should return a count of 0 but a sum of null.

fix typos in vtbackup.go

Signed-off-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Rasika Kale <rasika@planetscale.com>

v3: support overlapping multi-column vindexes

- Deleted Subtract() and Multiply() and other functions not related to Add() Signed-off-by: Rasika Kale <rasika@planetscale.com>

Addition expression implementation

healthcheck after backup should be run only for offline backups

…aster

Commits on Apr 1, 2019

Merge branch 'master' into prepare

dcadevil authored Apr 1, 2019

Configuration menu

View commit details

Copy full SHA for 2393ff7

Browse repository at this point

Copy the full SHA

2393ff7 View commit details

Browse the repository at this point in the history

Slack vitess 2019.08.26.r0 #137

Slack vitess 2019.08.26.r0 #137

Commits on Jan 15, 2019

Commits on Jan 16, 2019

Commits on Jan 17, 2019

Commits on Feb 23, 2019

Commits on Feb 24, 2019

Commits on Apr 1, 2019

Commits on Jun 17, 2019

Commits on Jun 18, 2019

Commits on Jun 28, 2019

Commits on Jun 30, 2019

Commits on Jul 10, 2019

Commits on Jul 15, 2019

Commits on Jul 16, 2019

Commits on Jul 17, 2019

Commits on Jul 20, 2019

Commits on Jul 22, 2019

Commits on Jul 23, 2019

Commits on Jul 24, 2019

Commits on Jul 29, 2019

Commits on Jul 30, 2019

Commits on Jul 31, 2019

Commits on Aug 1, 2019

Commits on Aug 4, 2019

Commits on Aug 5, 2019

Commits on Aug 6, 2019

Commits on Aug 7, 2019

Commits on Aug 8, 2019

Commits on Aug 9, 2019

Commits on Aug 10, 2019

Commits on Aug 11, 2019

Commits on Aug 12, 2019

Commits on Aug 13, 2019

Commits on Aug 14, 2019

Commits on Aug 15, 2019

Commits on Aug 16, 2019

Commits on Aug 17, 2019

Commits on Aug 18, 2019

Commits on Aug 19, 2019

Commits on Aug 20, 2019

Commits on Aug 21, 2019

Commits on Aug 22, 2019

Commits on Aug 23, 2019

Commits on Aug 24, 2019

Commits on Aug 26, 2019