Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to golang 1.12 #5017

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Updating to golang 1.12 #5017

merged 1 commit into from
Aug 20, 2019

Conversation

mpawliszyn
Copy link
Collaborator

Signed-off-by: Michael Pawliszyn mikepaw@squareup.com

@mpawliszyn
Copy link
Collaborator Author

mpawliszyn commented Jul 24, 2019 •
edited
Loading

The reason why I want this is to try out what should be better performance on TLS1.3 as well as there have been some general buffer and other changes to crypto/tls

I'm digging into the CPU performance and there is something around networks Syscalls. For this investigation to be useful it only really makes sense if I'm digging into the recent versions of these files.

@derekperkins
Copy link
Member

Not sure if all these spots are relevant, but this was the PR for bumping to 1.11 https://github.com/vitessio/vitess/pull/4246/files

@mpawliszyn mpawliszyn force-pushed the mikepaw.update-golang branch from d3f7631 to d9fe10f Compare July 29, 2019 14:24
@mpawliszyn
Copy link
Collaborator Author

mpawliszyn commented Jul 29, 2019 •
edited
Loading

Not sure if all these spots are relevant, but this was the PR for bumping to 1.11 https://github.com/vitessio/vitess/pull/4246/files

Ok I've added all the places from this PR now too

@sougou
Copy link
Contributor

sougou commented Aug 13, 2019

Conflicts need to be resolved.

@morgo
Copy link
Contributor

morgo commented Aug 13, 2019

The docs moved to vitessio/website -- these two .md files being here was just legacy. They've since been removed.

@mpawliszyn mpawliszyn force-pushed the mikepaw.update-golang branch from d9fe10f to 8fcf1ab Compare August 14, 2019 17:32
@morgo morgo mentioned this pull request Aug 17, 2019
Merged
@mpawliszyn
Copy link
Collaborator Author

@sougou I think the conflicts have been fixed.

@mpawliszyn
Updating to golang 1.12
63456f6 
Signed-off-by: Michael Pawliszyn <mikepaw@squareup.com>
@mpawliszyn mpawliszyn force-pushed the mikepaw.update-golang branch from 8fcf1ab to 63456f6 Compare August 20, 2019 17:15
@sougou sougou merged commit cbf78ca into vitessio:master Aug 20, 2019
@arka-g arka-g mentioned this pull request Sep 11, 2019
Merged
@morgo morgo mentioned this pull request Mar 20, 2020
Merged
@guidoiaquinti guidoiaquinti mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

@derekperkins derekperkins Awaiting requested review from derekperkins

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpawliszyn @derekperkins @sougou @morgo