Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrater: resharding_journal: participants change #5064

Merged
merged 1 commit into from
Aug 13, 2019
Merged

migrater: resharding_journal: participants change #5064

merged 1 commit into from
Aug 13, 2019

Conversation

sougou
Copy link
Contributor

@sougou sougou commented Aug 8, 2019

Make all sources as participants. It's not worth doing exact
computations in this case.

Signed-off-by: Sugu Sougoumarane ssougou@gmail.com

@sougou
migrater: resharding_journal: participants change
a78412a 
Make all sources as participants. It's not worth doing exact
computations in this case.

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
@sougou sougou requested review from deepthi and rafael August 8, 2019 22:41
deepthi
deepthi reviewed Aug 11, 2019
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test that covers this?

@sougou
Copy link
Contributor Author

sougou commented Aug 12, 2019

Is there a unit test that covers this?

Yes, the parts that verify the resharding journal are the tests.
We were actually missing a test for the previous code, which was to verify that only a subset of the participants get added if the streams were non-overlapping.

deepthi
deepthi approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sougou sougou merged commit 1b8dc21 into vitessio:master Aug 13, 2019
@sougou sougou deleted the ss-vrepl-participants branch August 14, 2019 03:37
@arka-g arka-g mentioned this pull request Sep 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@rafael rafael Awaiting requested review from rafael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sougou @deepthi