Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capabiltities followup cleanup PR #5069

Closed
wants to merge 4 commits into from

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Aug 9, 2019

This is a followup to #4987

It changes the Python default MYSQL_FLAVOR to MySQL56, to be the same as the Go default. The config file default-fast.cnf is renamed to testsuite.cnf because it should not be a recommended file: it serves the purpose of quickly init'ing a mysql server and running a small set of tests and then being torn down.

Unused sample config files are removed:

  • Production.cnf is a 2008 vision of production :-)
  • Backup.cnf and rdonly.cnf are blank and unused
  • Replica.cnf is redundant: these settings are set in other files, and for MySQL we recommend using table info repositories not files.

There will be further cleanup PRs. I want to try and break it down to be understandable by reviewers.

enisoc and others added 2 commits August 9, 2019 09:38
There are now a larger set of required templates because we have
auto-included files for every minor version (e.g. 5.6 vs 5.7).
Just include everything instead of trying to pick and choose.

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants