Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker/bootstrap: Add back VT_MYSQL_ROOT. #5185

Merged
merged 2 commits into from
Sep 13, 2019

Conversation

enisoc
Copy link
Member

@enisoc enisoc commented Sep 12, 2019

Without this, all tests fail because Vitess can't find mysqld:

failed init mysql: mysqld not found in any of /vt/{sbin,bin,libexec,scripts}

@enisoc enisoc requested a review from dkhenry as a code owner September 12, 2019 20:53
@morgo
Copy link
Contributor

morgo commented Sep 12, 2019

Sorry, this is my bad. It was removed in #5109

Is it possible to add CI so that it will fail if broken?

@enisoc enisoc requested a review from sougou as a code owner September 12, 2019 21:10
Without this, all tests fail because Vitess can't find mysqld:

failed init mysql: mysqld not found in any of
/vt/{sbin,bin,libexec,scripts}

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Since all Go tools have been removed from bootstrap.

Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
@enisoc enisoc force-pushed the docker-bootstrap-fix branch from 7266fdf to f97a82b Compare September 12, 2019 21:29
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing this through to fix broken build.

@sougou sougou merged commit 2e650aa into vitessio:master Sep 13, 2019
@enisoc enisoc deleted the docker-bootstrap-fix branch September 13, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants