add support for DEFAULT in insert statements for sequences to the query planner #5277
Conversation
mc0
force-pushed
the
addSupportForInsertDefault
branch
2 times, most recently
from
a9ce776
to
24be5d0
Compare
The only place swapBindVariables is called is for swapping out sequences. |
|
LGTM |
|
Closed by mistake. So sorry. |
mc0
force-pushed
the
addSupportForInsertDefault
branch
from
24be5d0
to
22833a9
Compare
go/vt/vtgate/planbuilder/insert.go
Outdated
| @@ -232,6 +232,9 @@ func modifyForAutoinc(ins *sqlparser.Insert, eins *engine.Insert) error { | |||
| func swapBindVariables(rows sqlparser.Values, colNum int, baseName string) (sqltypes.PlanValue, error) { | |||
| pv := sqltypes.PlanValue{} | |||
| for rowNum, row := range rows { | |||
| if _, ok := row[colNum].(*sqlparser.Default); ok { | |||
There was a problem hiding this comment.
One minor nit: It's better to move this code into modifyForAutoinc because it's now specific to that context. Otherwise, there's a risk that someone may accidentally reuse this function for other purposes.
There was a problem hiding this comment.
I agree with this conceptually. I was just trying to not add another loop for the sake of performance. Should I rename this function instead?
There was a problem hiding this comment.
Sorry, I think I misread what you suggested. If I move this code into modifyForAutoinc, I think we'd like this function to be deleted as well. Is that correct?
There was a problem hiding this comment.
Right. I think this function was previously reused, but it looks like I inlined it for the other use case.
…ry planner This will treat DEFAULT as "null" for the purposes of sequences when running insert statements. This matches with MySQL's documented behavior and observed resulted. See for more information: https://dev.mysql.com/doc/refman/8.0/en/data-type-defaults.html Signed-off-by: Mark Caudill <mark@sharpspring.com>
mc0
force-pushed
the
addSupportForInsertDefault
branch
from
22833a9
to
53949d3
Compare
This will treat DEFAULT as "null" for the purposes of sequences when
running insert statements. This matches with MySQL's documented
behavior and observed resulted.
See for more information:
https://dev.mysql.com/doc/refman/8.0/en/data-type-defaults.html