Add GitHub action for local example #5414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4989
The
local_example
test does not require any Python. It is also based on the documentation for contributing Vitess.This PR creates a GitHub action to install it using the same steps as on the docs: which is nice, because if a dependency sneaks in we will know the website is out of date.
It does not use
bootstrap.sh
, but a copy of it (what I hope will eventually be the primary bootstrap, but I am having trouble ( #5382 ) getting it to retrofit with the existing CI due to Docker cache. If I disable cache it works.. but tests time out.)This uses the layout of building from a single directory. It does not require
build.env
ordev.env
to build. It only uses it in bootstrap for the goversion_min function.Once this merges and is verified as working, we can move local_example to shard 5 (unused) in the CI so it doesn't have to run redundantly.
As more tests are converted to pure-go, we can add them as GitHub Actions. I evaluated CircleCI / Travis / CodeBuild and GitHub actions, and I think this is the best way to move forward.
Note: it uses Go 1.13, which is not a requirement. I compared it to Go 1.12, and it's about 30 seconds faster to download dependencies because I assume it uses a Go module proxy.
Signed-off-by: Morgan Tocker tocker@gmail.com