Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action for local example #5414

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Nov 6, 2019

Part of #4989

The local_example test does not require any Python. It is also based on the documentation for contributing Vitess.

This PR creates a GitHub action to install it using the same steps as on the docs: which is nice, because if a dependency sneaks in we will know the website is out of date.

It does not use bootstrap.sh, but a copy of it (what I hope will eventually be the primary bootstrap, but I am having trouble ( #5382 ) getting it to retrofit with the existing CI due to Docker cache. If I disable cache it works.. but tests time out.)

This uses the layout of building from a single directory. It does not require build.env or dev.env to build. It only uses it in bootstrap for the goversion_min function.

Once this merges and is verified as working, we can move local_example to shard 5 (unused) in the CI so it doesn't have to run redundantly.

As more tests are converted to pure-go, we can add them as GitHub Actions. I evaluated CircleCI / Travis / CodeBuild and GitHub actions, and I think this is the best way to move forward.

Note: it uses Go 1.13, which is not a requirement. I compared it to Go 1.12, and it's about 30 seconds faster to download dependencies because I assume it uses a Go module proxy.

Signed-off-by: Morgan Tocker tocker@gmail.com

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo requested a review from sougou as a code owner November 6, 2019 19:42
@deepthi
Copy link
Member

deepthi commented Nov 6, 2019

This is great! How can we see the result of the github action?

@morgo
Copy link
Contributor Author

morgo commented Nov 6, 2019

This is great! How can we see the result of the github action?

You can see it where the fork is, so in this case PlanetScale: https://github.com/planetscale/vitess/actions

I really like the way GitHub does it. I saw one mention of limits being 20 actions per repo - so we can have that many .yml files for each of our tests and execute in parallel. Also: if we don't want to do some tests on push but on a schedule, Actions has first class support for that without having to set anything up.

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM.

@morgo morgo merged commit 79933cf into vitessio:master Nov 7, 2019
@morgo morgo deleted the morgo-gh-action branch November 7, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants