-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for TLS enabled etcd server connections. #5496
Add option for TLS enabled etcd server connections. #5496
Conversation
7573e0c
to
ce39731
Compare
go/vt/topo/etcd2topo/server_test.go
Outdated
cmd.Wait() | ||
os.RemoveAll(dataDir) | ||
server.Close() | ||
client.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be closing an unexported field from the server. Cleaning up internal resources is the job of the owning object (e.g. this should happen inside server.Close()
if necessary).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, will fix. Is there some equivalent of Drop
for golang? (A way to provide clean-up instructions that are called automatically when the GC decides to clean an object up?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a way to do that in Go, but we do not speak of it because it must never be used. You didn't hear this from me. I was never here.
d25f623
to
24d7950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The unit test is failing:
I think you need to push the |
8378b32
to
e7f8717
Compare
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
db9437f
to
b75fef0
Compare
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
…sts. Updated server tests to use helper, and verified we are now working with https Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
…iewer. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Co-Authored-By: Anthony Yeh <enisoc@planetscale.com> Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
…ally by server object when server.close() is called Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
…t of it in tests. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
…se that client at the end of the function that establishes an etcd server for testing. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
b75fef0
to
1fe2abb
Compare
This PR adds the option for TLS enabled etcd server connections, and includes a test to confirm that when an etcd instance has been started with key, and cert, that a client setup with the correct TLS info can connect, put a value on a key, and retrieve that value off the key.