Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for TLS enabled etcd server connections. #5496

Merged
merged 22 commits into from
Dec 13, 2019
Merged

Add option for TLS enabled etcd server connections. #5496

merged 22 commits into from
Dec 13, 2019

Commits on Dec 12, 2019

  1. Added functionality for etcd tls support, and included tests. 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    8d6a921 View commit details
    Browse the repository at this point in the history

  2. Almost got tests working for tls etcd 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    4dc8c68 View commit details
    Browse the repository at this point in the history

  3. Changed to pass by value per review suggestion. 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    f2a458b View commit details
    Browse the repository at this point in the history

  4. Removed extra safety checks per review suggestion. 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    158465e View commit details
    Browse the repository at this point in the history

  5. Changed error return per review suggestion. 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    82d1ddd View commit details
    Browse the repository at this point in the history

  6. Update comments per review suggestion. 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    9881546 View commit details
    Browse the repository at this point in the history

  7. Moved common test logic into main tlstest file for access by other te… 

    …sts. Updated server tests to use helper, and verified we are now working with https

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    dbc614e View commit details
    Browse the repository at this point in the history

  8. Updated etcd2 flag names to etcd per convention as pointed out by rev… 

    …iewer.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    d169ff6 View commit details
    Browse the repository at this point in the history

  9. Update go/vt/topo/etcd2topo/server.go 

    Co-Authored-By: Anthony Yeh <enisoc@planetscale.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    1cdde0a View commit details
    Browse the repository at this point in the history

  10. Bring todo inside func so it doesn't get added into auto-generated docs 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    4a014a3 View commit details
    Browse the repository at this point in the history

  11. Removed client.close() from defer as this should get called automatic… 

    …ally by server object when server.close() is called

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    1aad001 View commit details
    Browse the repository at this point in the history

  12. Fixed up defers per review suggestions. 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    343ac9c View commit details
    Browse the repository at this point in the history

  13. Switched over to using server public api instead of pulling client ou… 

    …t of it in tests.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    542b81a View commit details
    Browse the repository at this point in the history

  14. Made sure that we retry until we establish an initial client, and clo… 

    …se that client at the end of the function that establishes an etcd server for testing.

Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    27d33f3 View commit details
    Browse the repository at this point in the history

  15. Adding logging to try to figure out why tests are failing 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    4df14d8 View commit details
    Browse the repository at this point in the history

  16. Setup stderr and stdout for debugging in cicd 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    9c059e2 View commit details
    Browse the repository at this point in the history

  17. Updating helper function to use DNS compatible common name 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    526f98f View commit details
    Browse the repository at this point in the history

  18. Corrected log for accuracy 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    f2c4f47 View commit details
    Browse the repository at this point in the history

  19. Corrected fatals message formatting 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    581131a View commit details
    Browse the repository at this point in the history

  20. Adding dns compliant server common name 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    52fd6b4 View commit details
    Browse the repository at this point in the history

  21. Changing these back so we break with logging in CICD. :-( 

    Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
    @PrismaPhonic @enisoc
    PrismaPhonic authored and enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    7ae6664 View commit details
    Browse the repository at this point in the history

  22. Pin unit test job to a specific version of etcd. 

    Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
    @enisoc
    enisoc committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    1fe2abb View commit details
    Browse the repository at this point in the history