Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vitess-mixin: add structure & first 2 dashboards #5609

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

guidoiaquinti
Copy link
Member

Description

First draft of the vitess-mixin: a set of Grafana dashboards, Prometheus rules and alerts, packaged together in a reuseable and extensible bundle.

Screen Shot 2019-12-20 at 4 32 43 PM

Why

Following the same path as other monitoring mixins. This mixin was heavily inspired by the kubernetes-mixin.

Disclaimer

This bundle is still a WIP:

  • It only generates Grafana dashboards
  • Prometheus rules and alerts are still missing
  • there's quite a bit of code duplication that could be refactored

I just rushed to push something out before 🎄Christmas to get a first feedback from the community.

Feedback are welcome, thanks and happy holidays!

Signed-off-by: Guido Iaquinti <giaquinti@slack-corp.com>
@dkhenry
Copy link
Contributor

dkhenry commented Jan 9, 2020

This looks like it might be a better fit in https://github.com/vitessio/contrib

@guidoiaquinti
Copy link
Member Author

👋@dkhenry thanks for your comment. I thought about it but I ended up pushing it here as this allow us to make changes to metrics and directly reflect those to Grafana dashboards, Prometheus rules and alerts at the same time without breaking anything. What do you think about it? Thanks!

@deepthi
Copy link
Member

deepthi commented Jan 16, 2020

This looks like it might be a better fit in https://github.com/vitessio/contrib

@dkhenry can you articulate why you don't think this should be in the main repo?

Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're willing to keep this up-to-date, then it's a good idea to make this part of the main repo. And I do trust that you will, since you're running this in production :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants