This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Slack sync upstream 2020 03 10.r0 #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
…tions Small Improvements to GitHub actions
The protoc generated code was not matching the goimports standard. I've added a goimports step after the build. This caused another breakage because time.proto did not match its package name of vttime. I've fixed that also. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
build: temporary unbreak for make proto
Fixes vitessio#5636 There was an unnecessary error check in a goroutine that could terminate late. The check has been removed. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
tests: fix panic in vstreamer_test
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Move flaky tests to _flaky_ + change unit/unit_race to go 1.13
The latest stream from "current" position feature introduced a hang in the vstreamer, if the subsequent DMLs started getting played before the vstreamer would start pulling from binlogs. The fix is to wait till we get a heartbeat before proceeding with the tests. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: RickyRajinder <singh.sangh@gmail.com>
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
vrepl: yet another vstreamer deflake
increased timeout of tablet status check
Add execute as root check to mysqlctl
…or the old vtctld webapp
Embed vtctld assets
Signed-off-by: Gary Edgar <gary@planetscale.com>
…er flag Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Fixes vitessio#5590 Previously the nextval code assumed that next_id will be changed externally. As explained in the bug, this can now happen with the new use cases. This change ensures that vttablet will work correctly even if next_id was changed. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
tools/make-release-packages.sh: stop packaging web dir
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Default testsuite to RBR
Support additional SHOW syntax
Signed-off-by: Roni He <herongrong2011@gmail.com>
Signed-off-by: Roni He <herongrong2011@gmail.com>
…s are ignored. Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Roni He <herongrong2011@gmail.com>
Deprecate disable_local_gateway flag.
…-patch Add web_dir options back so as to not break existing binaries. Options are ignored
Fix relay-log and relay-log-index paths
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Add percona 56 new dependency
Fixes vitessio#5752 DBClient was setting the connection to nil after close, which was causing vreplication to panic because it defers a Rollback on all connections. The safer thing is to close the connection, but not set it to nil. There's no test for DBClient, but I've manually verified that this won't panic any more. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
A file close was done before error checking, and the TestValidParallel name collided with TestValid when typing in `go test -run TestValid`. Signed-off-by: Jeff Hodges <jeff@somethingsimilar.com>
make sqlparser/parse_test.go nicer to work with
add DISTINCTROW to regular function without calling special token
This addresses symptoms, but not causes, discussed in vitessio#5755 and vitessio#5756 Signed-off-by: Jeff Hodges <jeff@somethingsimilar.com>
Fix vreplication panic
correct gofmt of vtctld and re-sync go.mod
…sio#5738) * first commit to use zk in tests Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Fixed zookeeper and added consul Signed-off-by: Ajeet jain <ajeet@planetscale.com> * added consul setup Signed-off-by: Ajeet jain <ajeet@planetscale.com> * added consul and zk2 tabletmanager tests in config Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Minor edits Signed-off-by: Ajeet jain <ajeet@planetscale.com> * fixing verticalsplit test Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Moving tabletmanager test to shard 18 Signed-off-by: Ajeet jain <ajeet@planetscale.com> * fixed reparent test Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Removing unrequired changes Signed-off-by: Ajeet jain <ajeet@planetscale.com> * review comments addressed Signed-off-by: Ajeet jain <ajeet@planetscale.com>
…itessio#5693) * initial commit for backup_only Signed-off-by: Ajeet jain <ajeet@planetscale.com> * changes in package structure Signed-off-by: Ajeet jain <ajeet@planetscale.com> * updating package name and fixing a test Signed-off-by: Ajeet jain <ajeet@planetscale.com> * removed unrequired teardown code Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Removed debug code Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Reset replication on mysql _before_ deleting vttablet from topo Signed-off-by: deepthi <deepthi@planetscale.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
) * initial commit for backup_only Signed-off-by: Ajeet jain <ajeet@planetscale.com> * changes in package structure Signed-off-by: Ajeet jain <ajeet@planetscale.com> * updating package name and fixing a test Signed-off-by: Ajeet jain <ajeet@planetscale.com> * removed unrequired teardown code Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Removed debug code Signed-off-by: Ajeet jain <ajeet@planetscale.com> * inital commit for xtrabackup Signed-off-by: Ajeet jain <ajeet@planetscale.com> * fix sequencing of cleanup Signed-off-by: Ajeet jain <ajeet@planetscale.com> * fix terminate restore for xtrabackup Signed-off-by: Ajeet jain <ajeet@planetscale.com> * updated config for xtrabackup Signed-off-by: Ajeet jain <ajeet@planetscale.com> * added xtrabackup stream mode Signed-off-by: Ajeet jain <ajeet@planetscale.com> * updated config for xtrabackup stream Signed-off-by: Ajeet jain <ajeet@planetscale.com> * minor changes to config Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Added percona 56 new dependency Signed-off-by: Ajeet jain <ajeet@planetscale.com> * Putting the dependency at right place Signed-off-by: Ajeet jain <ajeet@planetscale.com> * updated apt tp apt-get Signed-off-by: Ajeet jain <ajeet@planetscale.com> * corrected the typo Signed-off-by: Ajeet jain <ajeet@planetscale.com> * fixed a comma in config.json Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
Fix some typos in comments
upgrade aws-sdk-go to 1.28.8
remove reference to web/vtctld from Makefile
Signed-off-by: Morgan Tocker <tocker@gmail.com>
…ync-upstream-2020-03-10.r0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working through the commits.
Slack Changes
Not Slack Changes
MySQL Changes
🔴this is very scary to me. from my read it looks like if (a) a reparent happens OR (this is the scary part) (b) we get "Slave failed to initialize relay log info structure from the repository" when vttablet thinks it should replicating, then it will do a
stop slave; reset slave; start slavewhich causes it the replica to lose its position in the binary log.Advertise
FOUND ROWSfrom server to clientChanges to included my.cnf files
sqlparser now includes position information when parse errors happen
Backup changes
Put a buffered reader in front of xtrabackup's stdout, reducing vttablet memory usage during backup 🎉
VReplication Changes
Adds a "Materialize" command to vtctld which will be used to build other workflows.
Also does some refactors that touch resharding workflows
Adds
Migratecommand to migrate a table from one keyspace to another, withMigrateReadsandMigrateWriteto handle cutting over trafficAdd
write_onlyoption to consistent lookup vindexesCreateLookupVindex to add a lookup vindex on an existing table for the purpose of vreplicating that table to another keyspace
vtctld Changes
Embeds assets directly into
vtctldusing go.rice.Removes web dir from release packages
vttablet Changes
Prevents panic on vttablet shutdown caused by fully stopping the shard sync loop before closing the topo client
mysqlctl Changes
Prevents
mysqlctlfrom running as root.Pass env-vars to mysqld through mysqlctld
VTGate Changes
last_insert_id()anddatabase()in vtgate vitessio/vitess#5451 from systay:last_insert_idadds support for
database()andlast_insert_id()to the vtgate mysqlSimplify vtgate resolver and remove AggregateStats
Rollback connections on vtgate shutdown. This reduces or eliminates occurrences of
vttablet: rpc error: code = ResourceExhausted desc = transaction pool connection limit exceededduring vtgate deploys 🎉Topo Changes
allows
DeleteTabletof a former master to succeed without needing-allow_masterAdds a connection heartbeat to consul-topo watchers so watches don't remain stalled following a network partition
Mon/Viz Changes
Adds support for dotted tablenames in prom collectors, and uses non-panic versions of prom metrics creation functions
Workflow Changes
Build Changes
Test Changes
removes an error check in vstream_test that would cause it to errantly panic
marks to tests as flaky and updates unit and unit_race workflows from go1.12->go1.13
Migrates tabletmanager test cases from python
Disables 8.0 unit test 😦
Package Upgrades