Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent nil dereference error #5648

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jan 2, 2020

Don't use err.Error() because it is possible for err to be nil.

Signed-off-by: deepthi deepthi@planetscale.com

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner January 2, 2020 23:48
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is what made it flaky, we should make it non-flaky. If not, it can stay the way it is.

@deepthi
Copy link
Member Author

deepthi commented Jan 3, 2020

If this is what made it flaky, we should make it non-flaky. If not, it can stay the way it is.

I can't tell from the history whether this is the error we were getting earlier.
We could make it non-flaky and see if it starts failing with a different error. WDYT?

@sougou
Copy link
Contributor

sougou commented Jan 3, 2020

Try running it 10 times in a row, bonus points if you can overload your box while doing this. If it consistently passes, we can make it non-flaky.

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
Copy link
Member Author

deepthi commented Jan 3, 2020

Try running it 10 times in a row, bonus points if you can overload your box while doing this. If it consistently passes, we can make it non-flaky.

It passes the stress test on my local, so I have made it non-flaky.

@deepthi deepthi merged commit 8c15026 into vitessio:master Jan 3, 2020
@deepthi deepthi deleted the ds-fix-srvtopo-test branch January 3, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants