Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds context to sqlparser errors #5690

Merged
merged 2 commits into from
Jan 19, 2020
Merged

Adds context to sqlparser errors #5690

merged 2 commits into from
Jan 19, 2020

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Jan 11, 2020

Addresses #5682

Allows consumers of sqlparser parsing errors to inspect Pos and Near fields without depending on the format of the error message itself.

@cmoog cmoog requested a review from sougou as a code owner January 11, 2020 05:09
@cmoog
adds position and last token context to parse errors
b06eaae 
Signed-off-by: cmoog <moogcharlie@gmail.com>
@cmoog cmoog closed this Jan 14, 2020
@cmoog cmoog deleted the pos_parse_err branch January 14, 2020 03:10
@cmoog cmoog reopened this Jan 14, 2020
@cmoog
adds unit tests for PositionedErr parse error
5962d11 
Signed-off-by: cmoog <moogcharlie@gmail.com>
sougou
sougou approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice unintrusive change.

@sougou sougou merged commit 824f835 into vitessio:master Jan 19, 2020
@cmoog cmoog mentioned this pull request Jan 19, 2020
Merged
sougou added a commit that referenced this pull request Jan 19, 2020
@sougou
Merge pull request #5737 from cmoog/pos_parse_err
c9d2a14 
trivial patch to #5690 testing logic
@morgo morgo mentioned this pull request Jan 24, 2020
Closed
@ajm188 ajm188 mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmoog @sougou