tabletmanager: Fully stop shard sync loop on shutdown. #5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've received reports of a panic upon vttablet shutdown that we believe comes from the shard sync loop trying to restart its watch. This change ensures that the shard sync loop is fully stopped before we close the topology client. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
enisoc
force-pushed
the
stop-shard-sync
branch
from
1cd0642
to
09664ba
Compare
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
enisoc
force-pushed
the
stop-shard-sync
branch
from
09664ba
to
2e01914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've received reports of a panic upon vttablet shutdown that we believe comes from the shard sync loop trying to restart its watch. This change ensures that the shard sync loop is fully stopped before we close the topology client.
cc @rafael