Move flaky tests to _flaky_ + change unit/unit_race to go 1.13 #5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
morgo
changed the title
Signed-off-by: Morgan Tocker <tocker@gmail.com>
morgo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #5638 (I will leave open awaiting a fix), a test failed in this merge to master: https://github.com/vitessio/vitess/runs/369550719
Then in the CI for this, there was another flaky test: #5640
I am also changing the unit/unit_race tests to use golang 1.13. GitHub presumably has go module cache for 1.13 because it installs much faster (I was observing the dependency phase for unit and unit_race at 7 minutes+). These were originally held back to go 1.12 due to #5533 : but a workaround is now in place.
Signed-off-by: Morgan Tocker tocker@gmail.com