Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup transform tests migrated to go #5722

Merged
merged 15 commits into from
Jan 21, 2020
Merged

Backup transform tests migrated to go #5722

merged 15 commits into from
Jan 21, 2020

Conversation

princeparmar
Copy link
Contributor

Signed-off-by: pradip parmar prince.soamedia@gmail.com

@princeparmar
WIP: backup transform test completed
79f525b 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
review changes.
2ff33b8 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backp_transform: MANIFEST and backup files header validation.
b84670a 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
Merge branch 'master' into backup-transform
7715458 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup_transform: error validation in test_backup_error, small change…
e56b8a8 
…s in comments.

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup_transform: testcase added in config file.
c1f8dd4 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup_transform: folder renamed backup_tranform to backup_transform.…
bd6dfad 
… (removed typo error).

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup_transform: minor change regarding variable position.
2dd873e 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
Merge branch 'master' into backup-transform
027432b
@princeparmar princeparmar reopened this Jan 17, 2020
@princeparmar
bakup_transform: folder rename.
00fbc83 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup_transform: config updated.
e440884 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup_transform: vttablet start timeout increased to 25s from 10s.
88766ec 
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
Merge branch 'master' into backup-transform
009bf63
@deepthi deepthi changed the title Backup transform Backup transform tests migrated to go Jan 20, 2020
deepthi
deepthi reviewed Jan 20, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks on comments and function docs.

go/test/endtoend/backup/main_test.go Show resolved Hide resolved
go/test/endtoend/backuptransform/backup_transform_test.go Outdated Show resolved Hide resolved
go/test/endtoend/backuptransform/backup_transform_test.go Outdated Show resolved Hide resolved
go/test/endtoend/backuptransform/backup_transform_test.go Outdated Show resolved Hide resolved
go/test/endtoend/backuptransform/backup_transform_test.go Outdated Show resolved Hide resolved
go/test/endtoend/backuptransform/backup_transform_test.go Outdated Show resolved Hide resolved
go/test/endtoend/backuptransform/backup_transform_test.go Outdated Show resolved Hide resolved
go/test/endtoend/backuptransform/backup_transform_test.go Outdated Show resolved Hide resolved
go/test/endtoend/backuptransform/backup_transform_test.go Outdated Show resolved Hide resolved
go/test/endtoend/backuptransform/backup_transform_test.go Outdated Show resolved Hide resolved
@princeparmar
backup_transform: verify backup count and remove all backup added in …
6f2d75a 
…cluster utils.

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar
backup_transform: review changes related to some comments and list ba…
ffcf125 
…ckup function.

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
deepthi
deepthi approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit fb960d6 into vitessio:master Jan 21, 2020
@ajm188 ajm188 mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@princeparmar @deepthi