Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5654 after it was discovered that it does not work as intended when the config directory is not present!
Rice boxes do not support being called in an Init function, which means that without refactoring we can currently not use this feature for the init_db.sql file.Unfortunately this means that the examples need to find a path to init_db.sql. I am not really happy with the solution I went with, but I copied the config/init_db.sql file to examples/local.The alternative is that we could re-introduce VTROOT as a dependency, or add some sort of symlink in the repo + a copy on making packages. As I said - I'm not happy with the current solution, and really open to ideas.Thanks @enisoc : it now works as expected.
Edit: This has a second behavior change, which is that the embedded config is no longer rebuilt on
make build
. This created potentially noisy commits, since it kept bumping the timestamps. It also made the automated build system think it was working on dirty trees.Signed-off-by: Morgan Tocker tocker@gmail.com