Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve Connection: tablet server implementation #6313

Merged
merged 31 commits into from
Jul 1, 2020
Merged

Reserve Connection: tablet server implementation #6313

merged 31 commits into from
Jul 1, 2020

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Jun 15, 2020 •
edited
Loading

Linked to #6107

This adds support to allow reserve connections in tablet.

  1. This will allow modifying connection settings (tainting) and close connection rather than return the tainted connection back to pool.
  2. This will allow to add other feature on top of reserve connection where a dedicated connection is needed for a vtgate session like GET_LOCK(), RELEASE_LOCK(), etc.

@harshit-gangal harshit-gangal marked this pull request as draft June 15, 2020 07:00
@systay systay force-pushed the tablet-reserve-conn branch 2 times, most recently from 2708a71 to f94feb3 Compare June 15, 2020 14:46
@harshit-gangal harshit-gangal force-pushed the tablet-reserve-conn branch 3 times, most recently from 16848d3 to 6efce66 Compare June 17, 2020 06:59
@systay systay marked this pull request as ready for review June 17, 2020 15:04
deepthi
deepthi reviewed Jun 17, 2020
View reviewed changes
go/vt/vtctl/query.go Show resolved Hide resolved
go/vt/vterrors/aggregate.go Outdated Show resolved Hide resolved
go/vt/vttablet/queryservice/queryservice.go Show resolved Hide resolved
go/vt/vttablet/tabletserver/tx_engine.go Outdated Show resolved Hide resolved
@harshit-gangal harshit-gangal force-pushed the tablet-reserve-conn branch 2 times, most recently from cb10d13 to 5f1bc0c Compare June 20, 2020 12:49
systay and others added 17 commits June 29, 2020 10:21
@systay @harshit-gangal
Mostly implemented ReserveBeginExecute
c6f3ae6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@deepthi @harshit-gangal
Mostly implemented ReserveExecute
e18badd 
Signed-off-by: deepthi <deepthi@planetscale.com>
@harshit-gangal
reserved-conn: fix test
982991b 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
Added tainted and renew logic to connection
7699add 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: implements release method in tabletserver
3f71c83 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: use execRequest in tabletserver for tracing
9ff548a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: added txID test on reserveExecute method
626a702 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay @harshit-gangal
reserve-conn: allow reserving on a transaction
1606b07 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
reserve-conn: added tests around release
2c0d3cb 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
reserve-conn: Add ReserveExecute to the QueryService interface
26d2ffa 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
Add reserved id to QueryService.Execute
6bb1df3 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
reserve-conn: added reserveID to BeginExecute and Execute
40b63a3 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: used reserveId in Execute method and added endtoend on …
faf2657 
…tabletserver

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: use reserveID in beginExecute and added endtoend test f…
023096a 
…or same

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@deepthi @harshit-gangal
reserve-conn: add tests for ReserveBeginExecute
14b6205 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi @harshit-gangal
reserve-conn: QueryService.Commit now returns a new reservedID, TxEng…
490c04e 
…ine.Commit renews and taints the new connection. Added endtoend test for Commit with Reserve.

Signed-off-by: deepthi <deepthi@planetscale.com>
@harshit-gangal
reserve-conn: removed IStatefulConnection interface and use StatefulC…
75f82e3 
…onnection

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal and others added 11 commits June 29, 2020 10:21
@harshit-gangal
reserve-conn: removed tainted existing tainted reserve connection on …
ad3e631 
…commit

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: added reserve connection support in rollback
a6cf2d9 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay @harshit-gangal
Added endtoend tests
9cf4703 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
reserve-conn: added unhappy test related to using old reservedID
f2d4b9a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: added test that checks connection on failed execute query
11b0326 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: added preQueries endtoend test on reserveExecute and re…
5f69114 
…serveBeginExecute

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: added failing preQueries endtoend test on reserveExecut…
0452a14 
…e and reserveBeginExecute

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@deepthi @harshit-gangal
reserve-conn: consistent naming
436c615 
Signed-off-by: deepthi <deepthi@planetscale.com>
@harshit-gangal
reserve-conn: minor refactor
76ee1ec 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: added commit rollback execute failure test on reserved …
26f05f7 
…connection

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn: added Release method to QueryService interface
41640ee 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay @harshit-gangal
reserve-conn: add unit tests
98d0678 
Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay @harshit-gangal
reserve-conn: improved unit test coverage
e76b82b 
Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
deepthi
deepthi reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi
Apply suggestions from code review
bd3c8ba 
Signed-off-by: deepthi <deepthi@planetscale.com>
@sougou sougou merged commit 51f2555 into vitessio:master Jul 1, 2020
@systay systay mentioned this pull request Jul 15, 2020
Merged
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@deepthi deepthi deleted the tablet-reserve-conn branch July 31, 2020 16:00
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@harshit-gangal @deepthi @sougou @systay