Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve Connection: tablet server implementation #6313

Merged
merged 31 commits into from
Jul 1, 2020
Merged

Reserve Connection: tablet server implementation #6313

merged 31 commits into from
Jul 1, 2020

Commits on Jun 29, 2020

  1. Mostly implemented ReserveBeginExecute 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    c6f3ae6 View commit details
    Browse the repository at this point in the history

  2. Mostly implemented ReserveExecute 

    Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi @harshit-gangal
    deepthi authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    e18badd View commit details
    Browse the repository at this point in the history

  3. reserved-conn: fix test 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    982991b View commit details
    Browse the repository at this point in the history

  4. Added tainted and renew logic to connection 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    7699add View commit details
    Browse the repository at this point in the history

  5. reserve-conn: implements release method in tabletserver 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    3f71c83 View commit details
    Browse the repository at this point in the history

  6. reserve-conn: use execRequest in tabletserver for tracing 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    9ff548a View commit details
    Browse the repository at this point in the history

  7. reserve-conn: added txID test on reserveExecute method 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    626a702 View commit details
    Browse the repository at this point in the history

  8. reserve-conn: allow reserving on a transaction 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    1606b07 View commit details
    Browse the repository at this point in the history

  9. reserve-conn: added tests around release 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    2c0d3cb View commit details
    Browse the repository at this point in the history

  10. reserve-conn: Add ReserveExecute to the QueryService interface 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    26d2ffa View commit details
    Browse the repository at this point in the history

  11. Add reserved id to QueryService.Execute 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    6bb1df3 View commit details
    Browse the repository at this point in the history

  12. reserve-conn: added reserveID to BeginExecute and Execute 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    40b63a3 View commit details
    Browse the repository at this point in the history

  13. reserve-conn: used reserveId in Execute method and added endtoend on … 

    …tabletserver

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    faf2657 View commit details
    Browse the repository at this point in the history

  14. reserve-conn: use reserveID in beginExecute and added endtoend test f… 

    …or same

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    023096a View commit details
    Browse the repository at this point in the history

  15. reserve-conn: add tests for ReserveBeginExecute 

    Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi @harshit-gangal
    deepthi authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    14b6205 View commit details
    Browse the repository at this point in the history

  16. reserve-conn: QueryService.Commit now returns a new reservedID, TxEng… 

    …ine.Commit renews and taints the new connection. Added endtoend test for Commit with Reserve.

Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi @harshit-gangal
    deepthi authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    490c04e View commit details
    Browse the repository at this point in the history

  17. reserve-conn: removed IStatefulConnection interface and use StatefulC… 

    …onnection

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    75f82e3 View commit details
    Browse the repository at this point in the history

  18. reserve-conn: removed tainted existing tainted reserve connection on … 

    …commit

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    ad3e631 View commit details
    Browse the repository at this point in the history

  19. reserve-conn: added reserve connection support in rollback 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    a6cf2d9 View commit details
    Browse the repository at this point in the history

  20. Added endtoend tests 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    9cf4703 View commit details
    Browse the repository at this point in the history

  21. reserve-conn: added unhappy test related to using old reservedID 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    f2d4b9a View commit details
    Browse the repository at this point in the history

  22. reserve-conn: added test that checks connection on failed execute query 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    11b0326 View commit details
    Browse the repository at this point in the history

  23. reserve-conn: added preQueries endtoend test on reserveExecute and re… 

    …serveBeginExecute

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    5f69114 View commit details
    Browse the repository at this point in the history

  24. reserve-conn: added failing preQueries endtoend test on reserveExecut… 

    …e and reserveBeginExecute

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    0452a14 View commit details
    Browse the repository at this point in the history

  25. reserve-conn: consistent naming 

    Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi @harshit-gangal
    deepthi authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    436c615 View commit details
    Browse the repository at this point in the history

  26. reserve-conn: minor refactor 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    76ee1ec View commit details
    Browse the repository at this point in the history

  27. reserve-conn: added commit rollback execute failure test on reserved … 

    …connection

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    26f05f7 View commit details
    Browse the repository at this point in the history

  28. reserve-conn: added Release method to QueryService interface 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    41640ee View commit details
    Browse the repository at this point in the history

  29. reserve-conn: add unit tests 

    Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    98d0678 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. reserve-conn: improved unit test coverage 

    Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    e76b82b View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Signed-off-by: deepthi <deepthi@planetscale.com>
    @deepthi
    deepthi committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    bd3c8ba View commit details
    Browse the repository at this point in the history