Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename and deprecate RPCs, rename vars and files #6392

Merged
merged 1 commit into from
Jul 2, 2020
Merged

rename and deprecate RPCs, rename vars and files #6392

merged 1 commit into from
Jul 2, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jun 29, 2020

Signed-off-by: deepthi deepthi@planetscale.com

sougou
sougou reviewed Jul 1, 2020
View reviewed changes
proto/replicationdata.proto Outdated Show resolved Hide resolved
@deepthi
rename and deprecate RPCs, rename vars and files
1acb6e0 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
Copy link
Member Author

deepthi commented Jul 2, 2020 •
edited
Loading

@sougou this is ready for re-review.
Here's how I tested the proto changes:

  • Run vttablets in local example with new proto definitions
  • Start vtctld with older build (master w/o this PR changes)
  • test that ShardReplicationPositions works correctly. This tests the changes to replicationdata protobuf. I added more output locally to ShardReplicationPositions to validate the values of IoThreadRunning and SqlThreadRunning.
  • test ReparentTablet and PlannedReparentShard. These test the changes to SetMasterRequest where force_start_slave is being renamed to force_start_replication. One of them sends the value as false and one as true, so both possibilities are tested.
  • All these manual tests worked as expected. Verified by inspecting logs and cluster state.

@deepthi deepthi mentioned this pull request Jul 2, 2020
Merged
@deepthi deepthi requested review from acharis and zmagg July 2, 2020 19:17
@sougou sougou merged commit 03c5afd into vitessio:master Jul 2, 2020
@deepthi deepthi deleted the ds-rename-rpcs-vars branch July 6, 2020 18:59
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

@morgo morgo Awaiting requested review from morgo

@acharis acharis Awaiting requested review from acharis

@zmagg zmagg Awaiting requested review from zmagg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthi @sougou