Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1 of terminology changes #465

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Part 1 of terminology changes #465

merged 2 commits into from
Jul 3, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jul 2, 2020

This is a companion PR to vitessio/vitess#6392
slave has been changed to replica wherever possible. As we deprecate flags and commands in the code, we will make companion PRs for website docs to reflect the changes.

The eventual goal is to get consistent with the published mysql terminology:
https://mysqlhighavailability.com/mysql-terminology-updates/

Signed-off-by: deepthi deepthi@planetscale.com

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested review from morgo, acharis and zmagg July 2, 2020 19:15
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we have overlap between PRs :-) Mine was #461

Yours is now the superset, so I will close mine. Just one nit where I fixed it differently for readability (replicas via replication).

content/en/docs/reference/features/schema-management.md Outdated Show resolved Hide resolved
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
Copy link
Member Author

deepthi commented Jul 2, 2020

LGTM, we have overlap between PRs :-) Mine was #461

Yours is now the superset, so I will close mine. Just one nit where I fixed it differently for readability (replicas via replication).

Oh, sorry, I didn't realize you had an open PR.
I have made the one change you suggested. I will wait for the source code PR to be merged and then merge this one.

@deepthi
Copy link
Member Author

deepthi commented Jul 2, 2020

@morgo there are also refs in the chinese files. What do you recommend as a course of action for those?

@deepthi deepthi merged commit 30afaae into prod Jul 3, 2020
@shlomi-noach shlomi-noach deleted the ds-terminology-fixes branch July 12, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants