Allow INSERT with all defaults

go/test/endtoend/vtgate/sequence/seq_test.go

@@ -106,7 +106,12 @@ CREATE TABLE lookup_vindex (
  keyspace_id BLOB,
  UNIQUE KEY (c1, c2)
 );
-`
+
+CREATE TABLE allDefaults (
+ id bigint NOT NULL,
+ foo varchar(255),
+ primary key (id)
+);`
 
  shardedVSchema = `
  {
@@ -141,6 +146,18 @@ CREATE TABLE lookup_vindex (
  "column": "id",
  "sequence": "id_seq"
  }
+ }, 
+ "allDefaults": {
+ "columnVindexes": [
+ {
+ "column": "id",
+ "name": "hash"
+ }
+ ],
+ "autoIncrement": {
+ "column": "id",
+ "sequence": "id_seq"
+ }
  },
  "lookup_vindex": {
  "columnVindexes": [
@@ -253,7 +270,6 @@ func TestSeq(t *testing.T) {
  if err == nil || !strings.Contains(err.Error(), want) {
  t.Errorf("wrong insert: %v, must contain %s", err, want)
  }
-
 }
 
 func TestDotTableSeq(t *testing.T) {
@@ -278,3 +294,25 @@ func TestDotTableSeq(t *testing.T) {
  assert.Equal(t, "23000", mysqlErr.State)
  assert.Contains(t, mysqlErr.Message, "Duplicate entry")
 }
+
+func TestInsertAllDefaults(t *testing.T) {
+ defer cluster.PanicHandler(t)
+ ctx := context.Background()
+ vtParams := mysql.ConnParams{
+ Host: "localhost",
+ Port: clusterInstance.VtgateMySQLPort,
+ DbName: shardedKeyspaceName,
+ }
+ conn, err := mysql.Connect(ctx, &vtParams)
+ require.NoError(t, err)
+ defer conn.Close()
+
+ // inserting into a table that has default values for all columns works well
+ exec(t, conn, `insert into allDefaults () values ()`)
+ result := exec(t, conn, `select * from uks.id_seq`)
+ assert.Equal(t, 1, len(result.Rows))
+
+ // inserting into a table that does not have default values for all columns fails
+ _, err = conn.ExecuteFetch("insert into lookup_vindex () values ()", 0, false)
+ require.Error(t, err)
+}

go/test/endtoend/vtgate/unsharded/main_test.go

@@ -47,7 +47,11 @@ CREATE TABLE t1 (
  UNIQUE KEY (c3),
  UNIQUE KEY (c4)
 ) ENGINE=Innodb;
-`
+
+CREATE TABLE allDefaults (
+ id BIGINT NOT NULL AUTO_INCREMENT PRIMARY KEY,
+ name VARCHAR(255)
+) ENGINE=Innodb;`
  VSchema = `
 {
  "sharded": false,
@@ -71,6 +75,18 @@ CREATE TABLE t1 (
  "type": "VARCHAR"
  }
  ]
+ },
+ "allDefaults": {
+ "columns": [
+ {
+ "name": "id",
+ "type": "INT64"
+ },
+ {
+ "name": "name",
+ "type": "VARCHAR"
+ }
+ ]
  }
  }
 }
@@ -146,7 +162,22 @@ func TestSelectIntoAndLoadFrom(t *testing.T) {
  assertMatches(t, conn, `select c1,c2,c3 from t1`, `[[INT64(300) INT64(100) INT64(300)]]`)
 }
 
-func exec(t *testing.T, conn *mysql.Conn, query string) *sqltypes.Result { //nolint:golint,unused
+func TestInsertAllDefaults(t *testing.T) {
+ defer cluster.PanicHandler(t)
+ ctx := context.Background()
+ vtParams := mysql.ConnParams{
+ Host: "localhost",
+ Port: clusterInstance.VtgateMySQLPort,
+ }
+ conn, err := mysql.Connect(ctx, &vtParams)
+ require.NoError(t, err)
+ defer conn.Close()
+
+ exec(t, conn, `insert into allDefaults () values ()`)
+ assertMatches(t, conn, `select * from allDefaults`, "[[INT64(1) NULL]]")
+}
+
+func exec(t *testing.T, conn *mysql.Conn, query string) *sqltypes.Result {
  t.Helper()
  qr, err := conn.ExecuteFetch(query, 1000, true)
  require.NoError(t, err)
@@ -160,7 +191,7 @@ func execAssertError(t *testing.T, conn *mysql.Conn, query string, errorString s
  assert.Contains(t, err.Error(), errorString)
 }
 
-func assertMatches(t *testing.T, conn *mysql.Conn, query, expected string) { //nolint:golint,unused
+func assertMatches(t *testing.T, conn *mysql.Conn, query, expected string) {
  t.Helper()
  qr := exec(t, conn, query)
  got := fmt.Sprintf("%v", qr.Rows)

go/vt/sqlparser/parse_test.go

@@ -731,6 +731,9 @@ var (
  }, {
  input: "insert into user(format, tree, vitess) values ('Chuck', 42, 'Barry')",
  output: "insert into user(`format`, `tree`, `vitess`) values ('Chuck', 42, 'Barry')",
+ }, {
+ input: "insert into customer () values ()",
+ output: "insert into customer values ()",
  }, {
  input: "update /* simple */ a set b = 3",
  }, {