Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow INSERT with all defaults #6969

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Oct 29, 2020

Fixes #6651

Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
Copy link
Member

What about the sharded keyspace? If sharding column is auto-inc do we support it? If table is reference table do we support it?
We would need some safeguard around allowing insert with empty row.

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 4b2190c into vitessio:master Nov 2, 2020
@systay systay deleted the insert-all-defaults branch November 2, 2020 10:08
@askdba askdba added this to the v9.0 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INSERT with empty VALUES, found in Python sqlalchemy
3 participants