Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local docker: copy examples/common into /vt/common to match MoveTables user guide #7252

Conversation

mackenziestarr
Copy link
Contributor

Description

The current MoveTables user guide https://vitess.io/docs/user-guides/migration/move-tables/ doesn't work with the local dockerfile setup as the guide expects SQL files to be available in the relative path ../common. Because that directory isn't copied into the top-level /vt directory they aren't available for the entrypoint working directory. This PR copies examples/common into /vt/common to make the docker environment match the user guide expectations.

I'd also note that I tested this on the v8.0.0 tag, as make docker_local was broken for me the latest master:HEAD ea65a1c with Docker version 1.13.1 (admittedly an older version):

$ make docker_local
Building vitess/local
Sending build context to Docker daemon 235.2 MB
Step 1/22 : ARG bootstrap_version=0
Please provide a source image with `from` prior to commit
make: *** [docker_local] Error 1

could be related to #7182, happy to open a separate issue for it

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build

…Tables user guide

the MoveTables user guide https://vitess.io/docs/user-guides/migration/move-tables/
expects SQL files to be available in the relative path ../common

Signed-off-by: Mackenzie Starr <mackestarr@gmail.com>
@mackenziestarr mackenziestarr force-pushed the mstarr-fix-docker-local-for-movetables-user-guide branch from 23aac0d to 7851566 Compare January 5, 2021 19:49
Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 8e01691 into vitessio:master Jan 5, 2021
@mackenziestarr mackenziestarr deleted the mstarr-fix-docker-local-for-movetables-user-guide branch January 5, 2021 22:32
@askdba askdba added this to the v9.0 milestone Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants