Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the maxReplPosSearch struct out to topotools #7420

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Extract the maxReplPosSearch struct out to topotools #7420

merged 1 commit into from
Feb 1, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jan 31, 2021

Description

This is so later I can use it in both wrangler and grpcvtctldserver.
As a show of good faith (I was going to anyway but let's pretend!), I've
also added some test cases.

Signed-off-by: Andrew Mason amason@slack-corp.com

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@ajm188
Extract the maxReplPosSearch struct out to topotools
9c75b0b 
This is so later I can use it in both `wrangler` and `grpcvtctldserver`.
As a show of good faith (I was going to anyway but let's pretend!), I've
also added some test cases.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from sougou as a code owner January 31, 2021 21:04
doeg
doeg approved these changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + tests look great to me. I defer to PlanetScale friends on package structure. :)

rohit-nayak-ps
rohit-nayak-ps approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit abfacec into vitessio:master Feb 1, 2021
@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@ajm188 ajm188 deleted the am_extract_repl_pos_searcher branch March 4, 2021 21:32
setassociative pushed a commit to tinyspeck/vitess that referenced this pull request Mar 8, 2021
@rohit-nayak-ps @setassociative
Merge pull request vitessio#7420 from tinyspeck/am_extract_repl_pos_s…
c532bf9 
…earcher

Extract the `maxReplPosSearch` struct out to `topotools`
@setassociative setassociative mentioned this pull request Mar 8, 2021
Closed
@ajm188 ajm188 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@doeg doeg doeg approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
Component: Cluster management Type: Internal Cleanup
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ajm188 @doeg @rohit-nayak-ps @askdba