Gen4: fail more unsupported queries #8451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
added
Component: Query Serving
Type: Enhancement
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…ore3 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
frouioui
commented
Jul 15, 2021
Comment on lines
-115
to
+117
| // todo: add table | ||
| // tableNameMap[sqlparser.String()] = nil | ||
| for _, tblNames := range leftJoin.right.tableNames() { | ||
| tableNameMap[tblNames] = nil | ||
| } |
systay
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is the continuity of #8382. The goal is to support and/or fail more queries in gen4. This pull request ensures we error out queries that are not supposed to be supported, and return a
Gen4NotSupportederror for those that are not yet handled by the gen4 planner.Checklist