Gen4: Even more fixes #8904
Merged
Gen4: Even more fixes #8904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
changed the title
systay
added
Component: Query Serving
Type: Enhancement
systay
force-pushed
the
gen4-more-fixes
branch
from
d9cf06c
to
85584d2
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
…tble join planning Signed-off-by: Andres Taylor <andres@planetscale.com>
Now that all the queries are either planned correctly or failing with the expected error (Gen4NotSupported), we could simplify plan_test a lot Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
gen4-more-fixes
branch
from
3921b89
to
b382124
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
approved these changes
Sep 30, 2021
Comment on lines
+137
to
+144
| func orderedStringIntMap(in map[string]int) orderedMap { | ||
| result := make(orderedMap, 0, len(in)) | ||
| for k, v := range in { | ||
| result = append(result, keyVal{key: k, val: v}) | ||
| } | ||
| sort.Sort(result) | ||
| return result | ||
| } |
Comment on lines
+119
to
+121
| } | ||
| func (qg *QueryGraph) addJoinPredicates(ts semantics.TableSet, expr sqlparser.Expr) { | ||
| for _, join := range qg.innerJoins { |
There was a problem hiding this comment.
nit: add an extra new line between 119 and 120
| var checkAllTests = false | ||
| func testFile(t *testing.T, filename, tempDir string, vschema *vschemaWrapper) { | ||
| t.Run(filename, func(t *testing.T) { |
Comment on lines
+1656
to
+1691
| { | ||
| "QueryType": "SELECT", | ||
| "Original": "select col from unsharded union select id from user union select col2 from unsharded union select col from user_extra", | ||
| "Instructions": { | ||
| "OperatorType": "Distinct", | ||
| "Inputs": [ | ||
| { | ||
| "OperatorType": "Concatenate", | ||
| "Inputs": [ | ||
| { | ||
| "OperatorType": "Route", | ||
| "Variant": "SelectUnsharded", | ||
| "Keyspace": { | ||
| "Name": "main", | ||
| "Sharded": false | ||
| }, | ||
| "FieldQuery": "select col from unsharded where 1 != 1 union select col2 from unsharded where 1 != 1", | ||
| "Query": "select col from unsharded union select col2 from unsharded", | ||
| "Table": "unsharded" | ||
| }, | ||
| { | ||
| "OperatorType": "Route", | ||
| "Variant": "SelectScatter", | ||
| "Keyspace": { | ||
| "Name": "user", | ||
| "Sharded": true | ||
| }, | ||
| "FieldQuery": "select id from `user` where 1 != 1 union select col from user_extra where 1 != 1", | ||
| "Query": "select id from `user` union select col from user_extra", | ||
| "Table": "`user`" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More gen4 small fixes
Related Issue(s)
#7280
Checklist