Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gen4: Even more fixes #8904

Merged
merged 8 commits into from
Sep 30, 2021
Merged

Gen4: Even more fixes #8904

merged 8 commits into from
Sep 30, 2021

Commits on Sep 30, 2021

  1. Allows planning grouping on top of PulloutSubqueries 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    fc53864 View commit details
    Browse the repository at this point in the history

  2. allow UNION between * during planning and fail at run time instead 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    055c684 View commit details
    Browse the repository at this point in the history

  3. update test expectations 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    e6273d9 View commit details
    Browse the repository at this point in the history

  4. unflake query plan by sorting first 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    55686ae View commit details
    Browse the repository at this point in the history

  5. it was still flaky. removed the map in the querygraph to have predica… 

    …tble join planning

Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    96c7169 View commit details
    Browse the repository at this point in the history

  6. Simplified plan_test 

    Now that all the queries are either planned correctly or failing with
the expected error (Gen4NotSupported), we could simplify plan_test a lot

Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    b382124 View commit details
    Browse the repository at this point in the history

  7. Compact joins better 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    472bbd6 View commit details
    Browse the repository at this point in the history

  8. merge UNION DISTINCT more aggressively 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    16d39e2 View commit details
    Browse the repository at this point in the history