Ensure that hex query predicates are normalized for planner cache #9118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlord
force-pushed
the
NormalizeHexValuesInQueries
branch
14 times, most recently
from
7038e19 to
0ab3932
Compare
|
Making some progress: https://gist.github.com/mattlord/41575a480b667438e5e55ea3e740917b |
mattlord
force-pushed
the
NormalizeHexValuesInQueries
branch
7 times, most recently
from
624dc38 to
a9fed7e
Compare
mattlord
changed the title
mattlord
changed the title
mattlord
force-pushed
the
NormalizeHexValuesInQueries
branch
3 times, most recently
from
bb56452 to
1912acc
Compare
systay
reviewed
Nov 3, 2021
systay
reviewed
Nov 3, 2021
mattlord
force-pushed
the
NormalizeHexValuesInQueries
branch
2 times, most recently
from
e9f4e94 to
c130482
Compare
mattlord
force-pushed
the
NormalizeHexValuesInQueries
branch
2 times, most recently
from
6375eed to
aa83316
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
This is only dealing with HEXNUM valus, e.g. 0x01 Leaving Hex values, e.g. x'01', for later... Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
NormalizeHexValuesInQueries
branch
from
aa83316 to
e622ebd
Compare
3 tasks
mattlord
pushed a commit
to planetscale/vitess
that referenced
this pull request
Nov 5, 2021
…nQueries Ensure that hex query predicates are normalized for planner cache Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
pushed a commit
to planetscale/vitess
that referenced
this pull request
Nov 9, 2021
…nQueries Ensure that hex query predicates are normalized for planner cache Signed-off-by: Matt Lord <mattalord@gmail.com>
This was referenced Nov 22, 2021
3 tasks
DeathBorn
pushed a commit
to vinted/vitess
that referenced
this pull request
Jan 27, 2023
…lizeHexValuesInQueries vitessio@322ac09 using vitessio#9163 as a guide Merge pull request vitessio#9118 from planetscale/NormalizeHexValuesInQueries Ensure that hex query predicates are normalized for planner cache Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Vilius Okockis <vilius.okockis@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were not normalizing hex values of either format:
0x01x'73757265'This had a major performance impact in workloads where hex query predicates are used in common queries as we could not leverage the query planner cache. This work normalizes them.
Should we try and handle those here as well???
Related Issue(s)
#9101
Checklist