Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HexVal and HexNum type support to evalengine.Expr #9616

Closed
wants to merge 1 commit into from
Closed

Add HexVal and HexNum type support to evalengine.Expr #9616

wants to merge 1 commit into from

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Feb 2, 2022 •
edited
Loading

Description

In this commit 0d1a5e5, which was part of #9351, we broke HexVal and HexNum type support with Vindexes.

More specifically, HexVal and HexNum type support in vindex functions was lost in the transition from sqltypes.PlanValue to evalengine.Expr.

This work aims to add support for the HexVal and HexNum types in evalengine.Expr.

Related Issue(s)

Checklist

  • Should this PR be backported? YES, but ONLY to release-13.0
  • Tests were added or are not required
  • Documentation was added or is not required

@mattlord
Add vindex e2e test for HexNum and HexVal types
560e68e 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the evalengine_hextypesupport branch from 25f602c to 560e68e Compare February 2, 2022 04:13
@vmg vmg mentioned this pull request Feb 3, 2022
Merged
3 tasks
@mattlord
Copy link
Contributor Author

mattlord commented Feb 3, 2022

This is being replaced by: #9623

@mattlord mattlord closed this Feb 3, 2022
@mattlord mattlord deleted the evalengine_hextypesupport branch February 3, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay Awaiting requested review from systay systay is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattlord